Remove parallel usage in setup and test commands#8058
Merged
mitchellhenke merged 1 commit intomainfrom Mar 23, 2023
Merged
Conversation
Contributor
Should we just drop it? YAGNI and such, and whether we can trust that it actually works. |
Contributor
aduth
approved these changes
Mar 23, 2023
mitchellhenke
force-pushed
the
mitchellhenke/no-more-parallel
branch
from
ef0c06a to
4878fa2
Compare
changelog: Internal, Development, Remove parallel usage in setup and test commands
mitchellhenke
force-pushed
the
mitchellhenke/no-more-parallel
branch
from
4878fa2 to
69f878d
Compare
Contributor
Author
Sounds good to me, dropped it.
Oops, thank you, removed that as well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Based on discussion at yesterday's Engineering Huddle and people running into issues with the parallel testing being used by default, this PR removes
parallel_testsusage from the setup and test commands. It is still available for those who use it, but it will have to be run directly. I've also updated the gem.