LG-9118: Throttle phone verification on submit#8028
Merged
Conversation
solipet
approved these changes
Mar 22, 2023
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
A couple of comments, but otherwise looks great!
jmax-gsa
approved these changes
Mar 22, 2023
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
LGTM with a small suggestion.
Moving throttle to .submit out of .async_state_done
Move it closer to the source, next to the attempts API call.
It's possible, on the user's last available attempt, for them to succeed, but leave the throttle tripped. So check for success before checking for a throttled state.
…ate limitingi check from view to submission
This nil return stood out like a sore thumb.
matthinz
force-pushed
the
matthinz/9118-phone-throttle
branch
from
c73f084 to
e812a5c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9118
🛠 Summary of changes
Previously we were throttling phone verification when the phone verification screen was shown rather than when the form was submitted. This PR moves throttle checks to form submission.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.