Fix spec flake in GpoConfirmationUploader#8024
Merged
zachmargolis merged 2 commits intomainfrom Mar 20, 2023
Merged
Conversation
changelog: Internal, Tests, Fix test that flaked due to clock drift
Merged
soniaconnolly
added a commit
that referenced
this pull request
Mar 20, 2023
* LG-8887: In-Person Proofing: Add Login.gov logo above the Barcode (#7956) * WIP commit of half-baked changes for showing logo These are not yet functional * changelog: User-Facing Improvements, In-Person Proofing, Display Login.gov logo above barcode in email * Include asset_url * Revert "Include asset_url" This reverts commit a4612d2. * Revert "changelog: User-Facing Improvements, In-Person Proofing, Display Login.gov logo above barcode in email" This reverts commit 2f5326c. * Revert "WIP commit of half-baked changes for showing logo" This reverts commit c8d3af5. * WIP * Display miniature logo inside mailer and component view * Add a little padding * Drop skip_pipeline; simplify styles * Add image assertion * Allow alternative extensions --------- Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * LG-8788: Refactor address search controller (#7820) * changelog: Internal, In-Person Proofing, refactor some error reporting (analytics * Add server error to address search controller * refactor --------- Co-authored-by: Eileen McFarland <eileenmcfarland@navapbc.com> * Revert "Remove send link step (#7929)" (#8019) This reverts commit 8340d0a. This caused errors in prod from the send_link route, which shouldn't be happening. Possibly because of the 50/50 state. Reverting pending further research. * Correct analytics name send_link to link_sent (#8022) * Correct analytics name for link sent event to 'IdV: doc auth link_sent submitted' from 'IdV: doc auth send_link submitted' [skip changelog] * Add email support test case to mailer shared examples (#8017) * Add email support test case to mailer shared examples changelog: Internal, Automated Testing, Enhance mailer tests to check for email client support features * Link support reference For future recall * Fix spec flake in GpoConfirmationUploader (#8024) changelog: Internal, Tests, Fix test that flaked due to clock drift * Clean up spec to stop stubbing .new * Revert "Merge pull request #8016 from 18F/stages-rc-2023-03-17-revert" This reverts commit 4c8419f, reversing changes made to 3741fd7. --------- Co-authored-by: Matt Gardner <wilburnforce@gmail.com> Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> Co-authored-by: Eileen McFarland <eileenmcfarland@navapbc.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I also made an unrelated change to stop stubbing
new)