Skip to content

Adds cancel link to header when not 2FA'd#802

Merged
brendansudol merged 1 commit intomasterfrom
ab-add-cancel-link
Dec 2, 2016
Merged

Adds cancel link to header when not 2FA'd#802
brendansudol merged 1 commit intomasterfrom
ab-add-cancel-link

Conversation

@el-mapache
Copy link
Contributor

Why:
Users might like a way to cancel out of their authentication process

**Why**:
Users might like a way to cancel out of their authentication process
@el-mapache
Copy link
Contributor Author

el-mapache commented Dec 1, 2016

  • We still see the cancel link on the Account Locked screen...not sure if this is desirable
  • Clicking cancel of course gives us the message 'you have been signed out'. Technically this is still true as the user's session is destroyed, but should there be a different message displayed to the user? Something like 'Sign in request cancelled.'

Copy link
Contributor

@pkarman pkarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and tests look great. I'm fine with language as is but that's not my call.

@brendansudol brendansudol merged commit 471d5a2 into master Dec 2, 2016
@brendansudol brendansudol deleted the ab-add-cancel-link branch December 2, 2016 21:05
amoose pushed a commit that referenced this pull request Feb 24, 2017
**Why**:
Users might like a way to cancel out of their authentication process
amoose pushed a commit that referenced this pull request Feb 28, 2017
**Why**:
Users might like a way to cancel out of their authentication process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants