LG-8867: New page to inform user of GPO only by solipet · Pull Request #8011 · 18F/identity-idp

solipet · 2023-03-16T21:24:10Z

🎫 Ticket

🛠 Summary of changes

Introduces a new interstitial page that a user starting IDV will see once before the Welcome page informing the user that due to technical difficulties, we can only allow address verification via a letter.

This page is shown to a user if any of the following config flags are set:

vendor_status_sms: full_outage
vendor_status_voice: full_outage
feature_idv_force_gpo_verification_enabled: true

Additionally, the user is not presented with an option to do the hybrid flow if any of the following config flags are set:

vendor_status_sms: full_outage
vendor_status_voice: full_outage
feature_idv_hybrid_flow_enabled: false

👀 Screenshots

Coming from a service provider:

Hitting the /verify path directly (not available in production):

Spanish translation:

French translation:

app/services/vendor_status.rb

app/controllers/idv/doc_auth_controller.rb

matthinz · 2023-03-16T22:02:38Z

app/services/vendor_status.rb

Should gpo_only? and allow_hybrid_flow? go in FeatureManagement, since they depend on vendor status and configuration? I have some similar code for an idv_available? method in #7970 that I put in there for that reason.

We renamed this class OutageStatus since the outage could be predicated on a vendor outage or a feature flag config option.

Hmm, I think I preferred the separation of VendorStatus and FeatureManagement. To me it is not necessarily clear what OutageStatus is reporting on -- who is having the outage? Is it us or a vendor?

I think there's a clear separation between:

VendorStatus - which vendors are operational right now? Which classes (e.g. idv) of vendors are having trouble right now

FeatureManagement - given the larger state of the application, including configuration and vendor availability, what features are currently available to users?

"Vendor" isn't really the right term either, though, because we aren't referring to vendors, but capabilities (ie, sms or voice).

As a middle ground, might I suggest we keep OutageStatus for services we use that are switched to out (phone etc) and FeatureManagement for user-facing features we want to be able to switch off, as @matthinz has suggested? In other words, let's move the gpo and hybrid screen switched to FeatureManagement but keep the rest as-is. Does that make sense?

Example:

def self.idv_hybrid_flow_enabled? return false if not IdentityConfig.store.feature_idv_hybrid_flow_enabled return false if OutageStatus.new.any_phone_vendor_outage? true end

That works for me. I also wonder about bringing the :sms and :voice vendors more in line with the other ones (by actually naming them in ruby source, similar to Idv vendors) might be better long-term, but I'm happy to punt that to another day.

config/locales/links/en.yml

config/routes.rb

app/views/idv/vendor_outage/show.html.erb

app/controllers/idv/outage_controller.rb

config/application.yml.default

app/views/idv/outage/show.html.erb

app/views/idv/gpo/index.html.erb

app/controllers/idv/doc_auth_controller.rb

matthinz

If the user restarts IdV (via a "Start Over" button), should we send them back to the outage notice screen instead of the welcome screen?

app/services/outage_status.rb

matthinz · 2023-03-22T23:22:21Z

spec/features/idv/doc_auth/verify_info_step_spec.rb

Is this SSN context block needed here? I think I don't see how it relates.

This is testing the version of the SSN step that is removed from the FSM (which is feature flagged) to make sure it's routing correctly. I'm not sure why it's showing up in this diff though. Something must have got moved around

That feature flag is deleted in main, so this file is out of date.

jmax-gsa

LGTM

matthinz · 2023-03-23T22:44:34Z

app/controllers/idv/gpo_only_warning_controller.rb

👍 this is a good name

matthinz

LGTM pending removing the ssn controller stuff in verify_info_step_spec.rb (and rebasing on main I guess). Nice work!

Co-authored-by: Doug Price <douglas.price@gsa.gov> changelog: User-Facing Improvements, vendor outage warnings, Pinpoint vendor outage screen

-- What 1. Updated header locales 2. Added session checking to controller for vendor_status 3. Added continue button 4. Updated the working test for page display

See added failing verify_info spec

Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>

Also removing unused locales

-- What 1. Updated the Outage show view to use the StatusPageComponent, for better uniformity; 2. Added a controller helper to determine which url to link to in the "Exit" button. In the case where there is an SP present and it has a valid return_to_sp_url set, the exit button will navigate to that URL. In all other cases it will return the user to the account page. NOTE: We had to change the yml configuration for local testing SPs so that it had a correct return_to_sp_url that we could actually test against. Co-authored-by: Douglas Price <douglas.price@gsa.gov>

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

if GPO verification is not enabled, redirect to vendor outage blocking page.

solipet requested a review from a team March 16, 2023 21:24

matthinz reviewed Mar 16, 2023

View reviewed changes

solipet commented Mar 17, 2023

View reviewed changes

config/routes.rb Outdated Show resolved Hide resolved

aduth reviewed Mar 17, 2023

View reviewed changes

app/views/idv/vendor_outage/show.html.erb Outdated Show resolved Hide resolved

eric-gade force-pushed the doug-lg-8867 branch 3 times, most recently from 8a5aa2a to 84bbd6a Compare March 17, 2023 18:09

matthinz mentioned this pull request Mar 20, 2023

Global IdV feature flag / new "IdV Unavailable" page #7970

Closed

3 tasks

solipet force-pushed the doug-lg-8867 branch 2 times, most recently from a9bb2dd to 10bca70 Compare March 20, 2023 22:28

solipet requested review from aduth, eric-gade, matthinz and theabrad March 21, 2023 20:56

aduth reviewed Mar 22, 2023

View reviewed changes

solipet force-pushed the doug-lg-8867 branch 2 times, most recently from c924aa2 to 6a01b2e Compare March 22, 2023 20:47

matthinz reviewed Mar 22, 2023

View reviewed changes

jmax-gsa approved these changes Mar 23, 2023

View reviewed changes

matthinz reviewed Mar 23, 2023

View reviewed changes

app/controllers/idv/gpo_only_warning_controller.rb Outdated

Copy link

Contributor

matthinz Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is a good name

solipet reacted with laugh emoji

matthinz approved these changes Mar 23, 2023

View reviewed changes

solipet force-pushed the doug-lg-8867 branch from f1a3cbc to 1332576 Compare March 24, 2023 14:02

eric-gade and others added 8 commits March 24, 2023 10:05

Intitial commit of vendor outage controller / view

6f3342d

Co-authored-by: Doug Price <douglas.price@gsa.gov> changelog: User-Facing Improvements, vendor outage warnings, Pinpoint vendor outage screen

First pass at interstitial outage page

fdbf976

-- What 1. Updated header locales 2. Added session checking to controller for vendor_status 3. Added continue button 4. Updated the working test for page display

Updating view and localizations

90d6f87

YAML linting

7474ba5

Skipping upload/hybrid-handoff during phone outage

9ab090d

[WIP] Pass to verify-info/gpo on phone outage

7089b45

See added failing verify_info spec

If no SP, use APP_NAME

ee52082

Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>

Correct link to status page

b697412

solipet and others added 25 commits March 24, 2023 10:05

adds feature_idv_hybrid_flow_enabled flag (default: true)

e3d7310

show a cancel link on gpo page if skipping phone finder

a42e5fe

renamed ial2 vendors to idv

d8b4357

specs for feature flags

6ee0004

Updating locales to use app_name

114d3de

Also removing unused locales

Refactoring predicate methods for redirecting

bc3ed85

rename VendorStatus to OutageStatus

c47ef75

renamed VendorOutageController to OutageController

b9b7977

lints

2afb44c

don't hardcode app name in translations

d5e4184

make normalize_yaml

3279933

lints

3b7a2c0

Update app/controllers/idv/outage_controller.rb

c2b7f73

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

Update app/views/idv/outage/show.html.erb

06025c0

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

review comments

170624d

Adding hybrid flow availability check to FeatureManagement

746c0e3

renamed enable_gpo_verification? to gpo_verification_enabled?

fcc6659

use FeatureManagement.idv_gpo_only? for control

31b93ea

if GPO verification is not enabled, redirect to vendor outage blocking page.

rename OutageController to GpoOnlyWarningController

e3ff95b

more specs

1209f3a

lints

fa94f45

Re-show the mail only page if the user starts over

3cbd951

lints! 🤬

78b730d

remove spec on obsolete config doc_auth_ssn_controller_enabled

e377397

solipet force-pushed the doug-lg-8867 branch from 1332576 to e377397 Compare March 24, 2023 14:05

solipet merged commit 4a1eb8b into main Mar 24, 2023

solipet deleted the doug-lg-8867 branch March 24, 2023 14:41

aduth mentioned this pull request Mar 27, 2023

Deploy RC 266 to Prod #8080

Merged

Conversation

solipet commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

👀 Screenshots

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eric-gade Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthinz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmax-gsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthinz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

solipet commented Mar 16, 2023 •

edited

Loading

eric-gade Mar 23, 2023 •

edited

Loading