Change the regular expression we use to determine if get to yes is viable#8002
Merged
Change the regular expression we use to determine if get to yes is viable#8002
Conversation
…able Before we use the get-to-yes feature we need to make sure that the base lexis nexis error refers to the scoring model verification. This is what implies that the checks failed and we can fallback to AAMVA. LexisNexis uses the code priority.scoring.model.verification.fail for some of its workflows. This commit changes the regex we use to match against the code to match that code. [skip changelog]
jmhooper
changed the title
aduth
approved these changes
Mar 16, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Is there a relevant fixture or spec we could update to add coverage for this?
Contributor
Author
The test that covers this is here. I did consider adding a new fixture and a new example for this, but it seemed like overkill. I can go ahead and update that fixture if we are worried the regex doesn't match. |
zachmargolis
added a commit
that referenced
this pull request
Mar 17, 2023
* Add columns to duplicate SSN reporting (LG-9191) (#7995) * Add profile_active column * Add count_active_ssn_fingerprint column * Handle nil activated_at values changelog: Internal, Reporting, Add report for duplicate SSNs * LG-9138: Allow state ID address fields in user PII (#7961) * Allow state ID address fields in user PII changelog: Upcoming features, Double address verification, Allow state ID address fields in user PII * Add more Pii attribute comments * Use existing state_id_jurisdiction field * Allow state_id_jurisdiction in feature tests * Allow PII for other events * Update brakeman gem (#7998) changelog: Internal, Security, Update brakeman gem * Clean up `ResolutionProofingJob` tests (#7996) The `ResolutionProofingJob` is the class that does much of the legwork during the verify step. Specifically, it does the following: 1. Communicates with ThreatMetrix if necessary 2. Communicates with InstantVerify 3. Communicates with AAMVA 4. Combines results through the `ResolutionResultAdjudicator` The tests for this class have been sophisticated and have combined a number of different ways of mocking out responses from vendors (e.g. webmocks or stubs of the vendor classes). This change attempts to simplify some of this by creating a helper for stubbing responses from vendors. Those helpers are used to re-implement simpler examples for the logic the tests test. Ideally this will allow us to more quickly make changes to the `ResolutionProofingJob`. [skip changelog] * Reduce device/event transactions by wrapping multiple writes in one transaction (#7999) changelog: Internal, Database, Reduce device/event transactions by wrapping multiple writes in one transaction * Don't make a request to AAMVA if verification is guaranteed to fail (#7997) * Don't make a request to AAMVA if verification is guaranteed to fail We implemented a feature that allowed us to use the response we get from AAMVA to cover attributes that fail the LexisNexis check during resolution. Specifically, the following attributes can be covered by AAMVA: - Address - Dob - State ID Number As part of this change we started sending requests to AAMVA even if the LexisNexis response failed. Previously this occurred even if the failed LexisNexis attributes could not be covered by the AAMVA response. This commit attempts to shed some load on AAMVA's service by not making requests to them if the attributes in a failed LexisNexis response cannot be covered by AAMVA. [skip changelog] * Disable primary database prepared statements if using database socket connection (#7990) changelog: Internal, Database, Disable primary database prepared statements if using database socket connection * Change the regular expression we use to determine if get to yes is viable (#8002) Before we use the get-to-yes feature we need to make sure that the base lexis nexis error refers to the scoring model verification. This is what implies that the checks failed and we can fallback to AAMVA. LexisNexis uses the code priority.scoring.model.verification.fail for some of its workflows. This commit changes the regex we use to match against the code to match that code. [skip changelog] * Disable advisory locks when using pgbouncer socket (#8003) Related PRs #7990 and #7967 This disables advisory locks when a DB socket is used as `pgbouncer` does not support advisory lock use in transaction mode. changelog: Internal, Database, Disable primary database advisory locks if using database socket connection * Remove `skip_legacy_state` method (#7991) * Remove `skip_legacy_state` method The `skip_legacy_state` method had 2 major problems: 1. The name implies that the new state is somehow a legacy state 2. It is hidden in the `check_ssn` code which makes it difficult to understand how a user moves from the verify info controller to the phone controller This method attempts to clean this up by removing `skip_legacy_state` method and moving its logic into more reasonable places in the verify info concern or into the `Idv::Session`. [skip changelog] * Update app/services/idv/session.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * delint --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Add additional prompts to UUID lookup and review rake tasks (#8001) changelog: Internal, utilities, Reuqest more information from users when calling investigative rake tasks Co-authored-by: Paul Hirsch <paul.hirsch@gsa.gov> * LG-9020 update ssn content (#8004) * add strings * update ssn views with changed content * changelog: User-Facing Improvements, ssn page, update text * Update have_description accessibility matcher for feature spec compatibility (#8010) changelog: Internal, Automated Testing, Improve compatibility of accessibility description matcher * Remove send link step (#7929) * attempt to squash everything * Adding clear_and_fill_in helper -- What This new helper method will first clear an input before inserting text into it during capybara tests. * Removing unused analytics event methods Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Changelog changelog: User-Facing Improvements, Updating Hybrid Handoff, finishing removal of feature-flagged combined hybrid handoff * changelog: User-Facing Improvements, Updating Hybrid Handoff, finishing removal of feature-flagged combined hybrid handoff (LG-8903) * Restore `pgcrypto` extension * Remove redundant assignment * Decrease find wait time in feature spec --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: eric-gade <eric.gade@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * LG-9050: Add password error handling (#7989) * Add additional feedback to password error handling changelog: User-Facing Improvements, Registration, Add additional feedback to password error handling * LG-9023: Remove phone helper text (#7917) * Remove phone example number text changelog: User-Facing Improvements, Authentication, Remove phone helper text * LG-9206 | Analytics logs irs_session_id (#8007) changelog: Internal, Analytics, Log irs_session_id with analytics * Lg 9089 user data ack (#7974) * LG-9089 Add IRS text to localdev.yml for testing changelog: Internal, Analytics, Add Policy Redirect * Remove arcgis_search_enabled feature flag (#8006) * Remove arcgis_search_enabled feature flag Why: This feature is now enabled in production and would not be expected to be reverted to pilot facilities, and its continued existence in the code creates confusion for other developers. * changelog: Internal, Feature Flags, Remove code associated with live features * Remove unused locale strings * LG-8887: Update Ready to Verify language to be simpler, more branded (#8009) * changelog: Improvements, In-Person Proofing, Update language to be simpler and branded * Add param * Remove custom initializers from GoodJob classes (#8015) **Why**: They interfere with the jobs being instantiated by the scheduler changelog: Internal, Reporting, Fix scheduled SSN and Daily Dropoff report jobs --------- Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Paul Hirsch <59626817+pauldoomgov@users.noreply.github.com> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Stephen Shelton <stephen.shelton@gsa.gov> Co-authored-by: Paul Hirsch <paul.hirsch@gsa.gov> Co-authored-by: Shannon A <20867088+svalexander@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov> Co-authored-by: eric-gade <eric.gade@gsa.gov> Co-authored-by: jc-gsa <104452882+jc-gsa@users.noreply.github.com> Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Luis H. Matos <ThatSpaceGuy@users.noreply.github.com> Co-authored-by: Matt Gardner <wilburnforce@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we use the get-to-yes feature we need to make sure that the base lexis nexis error refers to the scoring model verification. This is what implies that the checks failed and we can fallback to AAMVA.
LexisNexis uses the code priority.scoring.model.verification.fail for some of its workflows. This commit changes the regex we use to match against the code to match that code.