Conversation
zachmargolis
reviewed
Dec 1, 2016
package.json
Outdated
Contributor
There was a problem hiding this comment.
we just want to remove the scripts, right? Not remove the entire package.json?
Contributor
Author
There was a problem hiding this comment.
hah ooops I think I may have been to aggressive here.
Contributor
Author
There was a problem hiding this comment.
re-added the stuff we still use and force pushed :)
jessieay
force-pushed
the
jy-remove-pa11y-crawl
branch
from
a0a2a82 to
05da1e3
Compare
jessieay
force-pushed
the
jy-remove-pa11y-crawl
branch
from
05da1e3 to
f4a843d
Compare
**Why**: * We are now testing accessibility of all pages through axe-matchers / RSpec so Pa11y is duplicative
amoose
pushed a commit
that referenced
this pull request
Feb 24, 2017
**Why**: * We are now testing accessibility of all pages through axe-matchers / RSpec so Pa11y is duplicative
amoose
pushed a commit
that referenced
this pull request
Feb 28, 2017
**Why**: * We are now testing accessibility of all pages through axe-matchers / RSpec so Pa11y is duplicative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
RSpec so Pa11y is duplicative