Skip to content

Update eslint-plugin-import#7987

Merged
matthinz merged 3 commits intomainfrom
matthinz/update-eslint-plugin-import
Mar 15, 2023
Merged

Update eslint-plugin-import#7987
matthinz merged 3 commits intomainfrom
matthinz/update-eslint-plugin-import

Conversation

@matthinz
Copy link
Contributor

@matthinz matthinz commented Mar 14, 2023

yarn audit was warning about a vulnerability in the version of json5 used by the eslint-plugin-import package we were using. This PR applies yarn upgrade eslint-plugin-import to resolve the warning.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Contributor

aduth commented Mar 15, 2023

  • Can we upgrade the version specifier in package.json to the version in use? (i.e. ^2.26.0 to ^2.27.5)
  • I'd recommend running yarn-deduplicate to deduplicate a few of the dependencies in the new yarn.lock tree

@matthinz matthinz changed the title Update eslint-plugin-import Update eslint-plugin-import and rack Mar 15, 2023
@matthinz
Copy link
Contributor Author

I just had to add a rack update to this branch to get it passing in CI, please 🤺 if anyone on this chain has any issues with me landing it.

@mitchellhenke
Copy link
Contributor

I think the rack patch should be taken care of from #7983

@matthinz
Copy link
Contributor Author

Okey doke, I will revert & rebase on main

@matthinz matthinz force-pushed the matthinz/update-eslint-plugin-import branch from 454e234 to 3b0cf0f Compare March 15, 2023 16:37
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthinz matthinz changed the title Update eslint-plugin-import and rack Update eslint-plugin-import Mar 15, 2023
@matthinz matthinz merged commit 6d2a452 into main Mar 15, 2023
@matthinz matthinz deleted the matthinz/update-eslint-plugin-import branch March 15, 2023 16:58
svalexander pushed a commit that referenced this pull request Mar 16, 2023
* Update eslint-plugin-import

Fix warning in `yarn audit`

[skip changelog]

* Update version specifier for eslint-plugin-import

* Run yarn-deduplicate to reduce duplicate dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants