Skip to content

Remove querying from good_jobs table in heartbeat job#7984

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-good-job-stats
Mar 14, 2023
Merged

Remove querying from good_jobs table in heartbeat job#7984
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-good-job-stats

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Mar 14, 2023

🛠 Summary of changes

The queries in the job currently can result in pretty heavy table scans if the jobs table gets too deep. We do have other metrics that allow us to monitor the health of the job queue that scale better with load and throughput.

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-good-job-stats branch from 3ca6bf2 to e52963f Compare March 14, 2023 16:18
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-good-job-stats branch from e52963f to f4bfbc7 Compare March 14, 2023 17:31
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-good-job-stats branch from f4bfbc7 to c391f4d Compare March 14, 2023 19:14
changelog: Internal, Background Jobs, Remove querying from good_jobs table in heartbeat job
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-good-job-stats branch from c391f4d to 8f6a5c4 Compare March 14, 2023 20:22
@mitchellhenke mitchellhenke merged commit 8c45dcf into main Mar 14, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/remove-good-job-stats branch March 14, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants