Fix test that is inconsistent across daylight saving time changes#7977
Merged
mitchellhenke merged 0 commit intomainfrom Mar 13, 2023
Merged
Conversation
sheldon-b
approved these changes
Mar 13, 2023
Comment on lines
431
to
432
Contributor
There was a problem hiding this comment.
This looks fine to me to get the tests passing but I don't understand why it started failing. And I think this version will start failing once we go back to daylight savings in Fall
Contributor
Author
There was a problem hiding this comment.
Thank you, yeah, good point. I dug a bit and it seems like it's due to places where the tests use ActiveSupport::TimeZone['Central Time (US & Canada)'], which will change offsets across DST, instead of ActiveSupport::TimeZone[-6], which is what the job itself uses here.
I added a900e42 which should be more robust in that regard. I ran the tests for both Standard time and Daylight Saving time, and it passes in both cases, so I'm hopeful this addresses it.
mitchellhenke
deleted the
mitchellhenke/fix-daylight-saving-time-bug-in-usps-job-spec
branch
eileen-nava
added a commit
that referenced
this pull request
Mar 15, 2023
* Fix test that is inconsistent across daylight saving time changes (#7977) * Fix test that is inconsistent across daylight saving time changes changelog: Internal, Testing, Fix test that is inconsistent across daylight saving time changes * refactor to work consistently across DST * update state id page to include address fields * capture secondary address info on state id page * update translations * neaten up code * update translations * state id displays new fields but doesn't save to correct attributes * save to updated attributes * changelog: Upcoming Features, In-person proofing, collect state id address * fix html & yaml formatting * fix failing tests * add path expectation to spec * Fix bordered radio button styling * clean up build * respond to feedback --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
Merged
svalexander
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Fix test that is inconsistent across daylight saving time changes (#7977) * Fix test that is inconsistent across daylight saving time changes changelog: Internal, Testing, Fix test that is inconsistent across daylight saving time changes * refactor to work consistently across DST * update state id page to include address fields * capture secondary address info on state id page * update translations * neaten up code * update translations * state id displays new fields but doesn't save to correct attributes * save to updated attributes * changelog: Upcoming Features, In-person proofing, collect state id address * fix html & yaml formatting * fix failing tests * add path expectation to spec * Fix bordered radio button styling * clean up build * respond to feedback --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Looks like a hard-coded time frame was causing these tests to fail relatively consistently since the DST change.