LG-8947 Improve analytics for FraudRejectionDailyJob#7973
Merged
Conversation
| private | ||
|
|
||
| def analytics(user: AnonymousUser.new) | ||
| Analytics.new(user: user, request: nil, session: {}, sp: nil) |
Contributor
There was a problem hiding this comment.
Do we want to add this method to ApplicationJob instead of here, to mirror the definition in ApplicationController? It's memoized there and I wonder if we want to do that here too.
Where was analytics defined before this PR?
Contributor
Author
There was a problem hiding this comment.
It is defined explicitly in some other jobs like this. For example: here . We could place it in ApplicationJob, but I'm wondering if that should be a separate story to move all calls to analytics in jobs to ApplicationJob.
Contributor
There was a problem hiding this comment.
Making that a separate ticket makes sense to me.
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 14, 2023
changelog: Internal, IdV Fraud, Improve analytics on FraudRejectiondailyJob Improves the analytics to show the day the profile was rejected to compare with the day the profile entered the fraud_review_pending state
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, IdV Fraud, Improve analytics on FraudRejectiondailyJob
Improves the analytics to show the day the profile was rejected to compare with the day the profile entered the fraud_review_pending state