-
Notifications
You must be signed in to change notification settings - Fork 167
Global IdV feature flag / new "IdV Unavailable" page #7970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d964d3b
Route + controller for outage page
matthinz ec70d3c
View for outage page
matthinz 2b68a8b
Wire up exit button
matthinz 569f314
Add idv_available config && feature
matthinz c6e8dd9
Return error when IDV is unavailable
matthinz 2156ac2
Update translations
matthinz 57b9496
Remove unused spec file
matthinz a790712
Make French be in French:wq
matthinz 7e8f83d
Be less clever in erb
matthinz 6607faa
Fix borked rename
matthinz 66cbfb0
Remove unused tests
matthinz 5dd2ac2
Don't rely on route to test IdvController::unavailable
matthinz 2bba983
Revert formatting changes to routes.rb
matthinz f0ecbf4
Superstition: reload routes on cleanup to avoid poisoning other tests
matthinz db215ca
Remove stray to_h method
matthinz 434bf49
Don't use `raise` + concern for unavailable error
matthinz 081451e
Attempt to redirect user back from outage page
matthinz 1797426
changelog: User-Facing Improvements, Identity verification, Provide a…
matthinz bfc1934
Remove from, from_idv from VendorStatus
matthinz f0825fe
Log when we hit IDV unavailable screen from the create account page
matthinz 5e1a073
Remove unneeded VendorStatus test
matthinz 0137f4c
Fix #track_event test
matthinz f18d53f
Remove unused translations
matthinz ac1b7c5
Clean up unavailable actions / views / etc.
matthinz ac4f9fc
Hoist constant up to class level
matthinz 98f82b6
Remove unused action on IdvController
matthinz 4b39a0a
Fixup: unavailable view
matthinz e116e8e
Don't use separate actions for idv unavailable message
matthinz 6aa9f06
Spell "unavailable" correctly
matthinz 7689c7a
Use StatusPageComponent for IdV unavailable message
matthinz 82fb5d5
Return 200 OK from unavailable error page
matthinz 3e23672
Refactor redirect in UnavailableController out to before_action
matthinz ec9d077
Remove irrelevant test
matthinz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| module Idv | ||
| class UnavailableController < ApplicationController | ||
| ALLOWED_FROM_LOCATIONS = [SignUp::RegistrationsController::CREATE_ACCOUNT] | ||
|
|
||
| before_action :redirect_if_idv_available_and_from_create_account | ||
|
|
||
| def show | ||
| analytics.vendor_outage( | ||
| vendor_status: { | ||
| acuant: IdentityConfig.store.vendor_status_acuant, | ||
| lexisnexis_instant_verify: IdentityConfig.store.vendor_status_lexisnexis_instant_verify, | ||
| lexisnexis_trueid: IdentityConfig.store.vendor_status_lexisnexis_trueid, | ||
| sms: IdentityConfig.store.vendor_status_sms, | ||
| voice: IdentityConfig.store.vendor_status_voice, | ||
| }, | ||
| redirect_from: from, | ||
| ) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def from | ||
| params[:from] if ALLOWED_FROM_LOCATIONS.include?(params[:from]) | ||
| end | ||
|
|
||
| def from_create_account? | ||
| from == SignUp::RegistrationsController::CREATE_ACCOUNT | ||
| end | ||
|
|
||
| def redirect_if_idv_available_and_from_create_account | ||
| redirect_to sign_up_email_url if FeatureManagement.idv_available? && from_create_account? | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <% title t('idv.titles.unavailable') %> | ||
|
|
||
| <%= render StatusPageComponent.new(status: :error) do |c| %> | ||
|
|
||
| <% c.header { t('idv.titles.unavailable') } %> | ||
|
|
||
| <p> | ||
| <% if decorated_session.sp_name.present? %> | ||
| <%= t('idv.unavailable.idv_explanation.with_sp', sp: decorated_session.sp_name) %> | ||
| <% else %> | ||
| <%= t('idv.unavailable.idv_explanation.without_sp') %> | ||
| <% end %> | ||
| </p> | ||
|
|
||
| <p class="margin-bottom-5"> | ||
| <%= t( | ||
| 'idv.unavailable.next_steps_html', | ||
| app_name: APP_NAME, | ||
| status_page_link: new_window_link_to( | ||
| t('idv.unavailable.status_page_link'), | ||
| StatusPage.base_url, | ||
| ), | ||
| ) %> | ||
| </p> | ||
|
|
||
| <% c.action_button( | ||
| action: ->(**tag_options, &block) do | ||
| link_to( | ||
| return_to_sp_failure_to_proof_path(location: :unavailable), | ||
| **tag_options, | ||
| &block | ||
| ) | ||
| end, | ||
| big: true, | ||
| wide: true, | ||
| ).with_content(t('idv.unavailable.exit_button', app_name: APP_NAME)) %> | ||
|
|
||
| <% end %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.