Conversation
jmhooper
changed the title
#verify_info_step_complete? and `mark_verify_info_step_comple…#verify_info_step_complete? and mark_verify_info_step_complete! methods to Idv::Session
soniaconnolly
approved these changes
Mar 13, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! I pulled it down and tried to force redirects and everything behaved as expected.
jmhooper
force-pushed
the
jmhooper-new-mark-steps-complete-pattern
branch
2 times, most recently
from
65ed799 to
fc639fc
Compare
Merged
svalexander
pushed a commit
that referenced
this pull request
Mar 16, 2023
…te!` methods to `Idv::Session` (#7958) The IdV Session manages the session variables during proofing and is inspected throughout to determine if a user should be on a particular step. This means the session contains a series of flags or artifacts that determine if steps were completed. The names of these and the impacts of changing them may not be obvious, so in this commit some methods for marking a step complete and checking that a step is complete were added alongside methods for invalidating a step. This is a pattern we intend to apply to other steps in the proofing flow. changelog: Improvement, FSM Retirement, Methods were added to the Idv Session class for determining whether the verify info step was completed and for marking the verify info step complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IdV Session manages the session variables during proofing and is inspected throughout to determine if a user should be on a particular step. This means the session contains a series of flags or artifacts that determine if steps were completed. The names of these and the impacts of changing them may not be obvious, so in this commit some methods for marking a step complete and checking that a step is complete were added alongside methods for invalidating a step.
This is a pattern we intend to apply to other steps in the proofing flow.