LG-9002: Add in_person_capture_secondary_id_enabled feature flag#7949
LG-9002: Add in_person_capture_secondary_id_enabled feature flag#7949eileen-nava merged 4 commits intomainfrom
Conversation
allthesignals
left a comment
allthesignals
left a comment
There was a problem hiding this comment.
LGTM! We have other feature flags using ipp. Is that idea to move away from that naming convention?
sheldon-b
left a comment
sheldon-b
left a comment
There was a problem hiding this comment.
LGTM! One small suggestion
config/application.yml.default
Outdated
| voice_otp_speech_rate: 'slow' | ||
| voip_block: true | ||
| voip_allowed_phones: '[]' | ||
| in_person_capture_secondary_id_enabled: false |
There was a problem hiding this comment.
Can you move this up to the block of other in_person... config values, near line 144? This list is kinda-sorta sorted alphabetically and it'll be easier to find near other in-person values
There was a problem hiding this comment.
LGTM! We have other feature flags using
ipp. Is that idea to move away from that naming convention?
Yes, the idea is to use in_person instead of ipp. This naming convention transcends feature flags. For example, if you look at git history, you'll see that directories used to say "ipp" instead of "in_person." The idea is that the full phrase is clearer than an acronym.
3 participants
🎫 Ticket
(5) Implement LG-8692 (collecting current address if different)
Please note, this PR does not fully complete LG-9002. All it does is add the feature flag.
🛠 Summary of changes
in_person_capture_secondary_id_enabledfeature flag📜 Testing Plan
Inspect
application.yml.defaultandlib/identity_config.rb.Confirm that both contain the new feature flag.