Jmax/lg 9084 remove personal key in gpo feature flag#7948
Merged
Conversation
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
reviewed
Mar 8, 2023
Refactored step_indicator_concern spec in the process.
jmax-gsa
deleted the
jmax/LG-9084-remove-personal-key-in-gpo-feature-flag
branch
svalexander
pushed a commit
that referenced
this pull request
Mar 16, 2023
Removed feature flag and related code. Refactored step_indicator_concern spec in the process. [skip changelog] Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9084
🛠 Summary of changes
Removed the
gpo_personal_key_after_otpfeature flag. Updated code and specs accordingly.Testing Plan
gpo_personal_key_after_otpfeature flag to false in your application.yml file.