LG-9091: update consent screen for reverified accounts#7946
Merged
Conversation
zachmargolis
approved these changes
Mar 7, 2023
Comment on lines
-84
to
-106
| context 'when there is an active profile' do | ||
| let(:sp_session_identity) do | ||
| create(:service_provider_identity, last_consented_at: 15.days.ago, user: user) | ||
| end | ||
|
|
||
| before do | ||
| create(:profile, :active, verified_at: verified_at, user: user) | ||
| end | ||
|
|
||
| context 'when the active profile was verified after last_consented_at' do | ||
| let(:verified_at) { 5.days.ago } | ||
| it 'is true because the new verified data needs to be consented to sharing' do | ||
| expect(consent_has_expired?).to eq(true) | ||
| end | ||
| end | ||
|
|
||
| context 'when the active profile was verified before last_consented_at' do | ||
| let(:verified_at) { 20.days.ago } | ||
| it 'is false' do | ||
| expect(consent_has_expired?).to eq(false) | ||
| end | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
were these cases removed because they're covered by the tests below? or changed by the new behavior?
Contributor
Author
There was a problem hiding this comment.
changed by the new behavior. Right now the consent expired handled both cases, but the language for a reverification should be different than when a consent expires technically.
aduth
reviewed
Mar 7, 2023
…t-screen-for-reverified-accounts
aduth
approved these changes
Mar 8, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Looks great 👍 Tested locally as well.
mdiarra3
deleted the
LG-9091-update-consent-screen-for-reverified-accounts
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9091: New Consent Screen for reverified Users
🛠 Summary of changes
Add new consent screen
👀 Screenshots
If user reverifies and then goes to the completion screen they will be shown text below.
