Log LexisNexis errors even on successful transactions#7943
Merged
Conversation
In the past we have not logged errors from the response on passed LexisNexis transaction. The assumption here was that if the transaciton passed there must not be any errors. Due to nuances in the configuration LexisNexis transacitons can pass if there are tolerable errors or errors that are not deemed risky enough to fail a transaction. These still contain useful information, however. This commit makes a change to always log the errors in LexisNexis transacitons, even if they are successful. changelog: Improvements, Error logging, Errors that occur while communicating with LexisNexis Risk Defense Platform services (i.e. InstantVerify and PhoneFinder) are now logged regardless of the verification status of the RDP transaction.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…ty-idp into jmhooper-log-ln-errors-always
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we have not logged errors from the response on passed LexisNexis transaction. The assumption here was that if the transaciton passed there must not be any errors.
Due to nuances in the configuration LexisNexis transactions can pass if there are tolerable errors or errors that are not deemed risky enough to fail a transaction. These still contain useful information, however.
This commit makes a change to always log the errors in LexisNexis transactions, even if they are successful.