Add #confirm_verify_info_step_complete to the IdV step concern#7941
Add #confirm_verify_info_step_complete to the IdV step concern#7941
#confirm_verify_info_step_complete to the IdV step concern#7941Conversation
With the retirment of the Flow State Machine we will be using the IdV step concern to confirm that steps are completed throughout the proofing flow. This commit adds a `#confirm_verify_info_step_complete` which can be used as a before action to confirm verify info is complete. If it is not complete it knows to redirect the user either to the remote verify info or in-person verify info depending on whether the user has a in-person enrollmemnt. changelog: Improvements, FSM Retirement, A before action that validates that the verify info step was completed was added for use in IdV controllers that render steps that require the verify step to have been completed.
| service_provider: nil, | ||
| ) | ||
| idv_session.profile_confirmation = true | ||
| idv_session.resolution_successful = 'phone' |
There was a problem hiding this comment.
silly question... does GPO flow not use this controller?
There was a problem hiding this comment.
So, long story here. The GPO flow does use this controller. This value, however, is not related at all to the GPO flow or the phone flow for that matter. It is a value that the Flow State Machine set starting a while back that, as best as I can tell, was a copy/paste error.
We've kept using the phone value for continuity. I've been talking with @soniaconnolly about removing resolution_successful in favor of just using profile_confirmation. That may take some work to make sure things don't break in the 50/50 state.
There was a problem hiding this comment.
For reference, here is where this gets set when the profile is verified. This code was copied over from the verify step in the flow state machine. You can also see where the likely typo occurred.
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Pulled down the code, was unable to break.
Did get one unexpected issue with SSN entry "cannot verify your details", which worked fine the next time. Don't think that's specific to this PR, since I didn't get it to happen again.
3 participants
With the retirment of the Flow State Machine we will be using the IdV step concern to confirm that steps are completed throughout the proofing flow.
This commit adds a
#confirm_verify_info_step_completewhich can be used as a before action to confirm verify info is complete. If it is not complete it knows to redirect the user either to the remote verify info or in-person verify info depending on whether the user has a in-person enrollmemnt.