Conversation
changelog: Bug Fixes, In-Person Proofing, Retain State ID and Address on form re-render after invalid submissions
4 tasks
5 tasks
zachmargolis
reviewed
Mar 7, 2023
jmhooper
approved these changes
Mar 7, 2023
Contributor
jmhooper
left a comment
There was a problem hiding this comment.
This looks like it should work. I think the fact that the forms get memoized is not very obvious to people implementing steps. That is, unfortunately however, the nature of the flow state machine and the reason we are discarding it.
I will say, related to it be non-obvious, I think we could do a lot of work on the commit message here. Doing so will help future readers understand what this change is doing and what its purpose is. Please make sure to write a descriptive message when you merge that provides context for why this change is necessary and describes how it solves that problem.
zachmargolis
reviewed
Mar 7, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…ley/lg-7832-transliterate-usps-api-fix-forms
…ttps://github.com/18F/identity-idp into tbradley/lg-7832-transliterate-usps-api-fix-forms
Contributor
Author
|
@jmhooper I included details about how and why this change works in the squash commit message. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
requiredattribute from theFirst namefieldFirst nameFirst namefieldNote: Previous behavior was to re-render the same form with no error and with all fields blank.