Add #confirm_address_step_complete to the Idv Step Concern#7931
Merged
Add #confirm_address_step_complete to the Idv Step Concern#7931
#confirm_address_step_complete to the Idv Step Concern#7931Conversation
The IdV step concern is intended to be used to make certain that previous IdV steps have been completed before allowing a user to complete a step. This commit start the process of implementing these steps by adding an available before action to ensure the address step is complete and using that in the review controller changelog: Internal, Improvements, A before action to verify that the user has completed the address step before allowing the user to complete steps that depend on the address step was added to IdV step concern so it is available to controllers that implement IdV steps.
soniaconnolly
approved these changes
Mar 6, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. I pulled it down and was unable to break it.
I did notice an interesting side issue. /verify/doc_auth/anything redirects to the next FSM step. I tried /verify/doc_auth/review from the /verify/verify_info step (because I didn't realize it's actually /verify/review) and it redirected to the ssn step. Then, verify/verify_info does correctly go back to verify_info step. This happens on main too, not caused by this PR.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IdV step concern is intended to be used to make certain that previous IdV steps have been completed before allowing a user to complete a step. This commit start the process of implementing these steps by adding an available before action to ensure the address step is complete and using that in the review controller