LG-8969: Update error content for po search#7928
Merged
gina-yamada merged 8 commits intomainfrom Mar 7, 2023
Merged
Conversation
gina-yamada
commented
Mar 6, 2023
gina-yamada
changed the title
gina-yamada
requested review from
a team,
JackRyan1989 and
WheresHJ
and removed request for
a team
JackRyan1989
reviewed
Mar 6, 2023
| ); | ||
|
|
||
| const error = await findByText('idv.failure.exceptions.internal_error'); | ||
| const error = await findByText('idv.failure.exceptions.post_office_search_error'); |
Contributor
There was a problem hiding this comment.
This looks pretty good to me. I think these are the two tests we want to run, I'm just wondering if there are other failures we might encounter? I didn't see anything in the spec for spec/services/usps_in_person_proofing/proofer_spec.rb that would seem to indicate other failure states we might encounter, but I wanted to double check.
JackRyan1989
approved these changes
Mar 6, 2023
Contributor
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Small non-blocking question.
aduth
reviewed
Mar 6, 2023
Contributor
Author
|
Waiting for design approval (user facing change) |
| exceptions: | ||
| internal_error: There was an internal error processing your request. Please try again. | ||
| link: please contact us | ||
| post_office_search_error: We are having technical difficulties at the moment. |
There was a problem hiding this comment.
I reviewed the screen shots and text in all languages. Looks good to me!
gina-yamada
deleted the
yamada/LG-8969-update-for-temp-500-err-on-po-search
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8969
🛠 Summary of changes
📜 Testing Plan
npm test app/javascript/packages/document-capture/components/in-person-location-post-office-search-step.spec.tsx- all 755 tests are passing (including the ones I edited- see screenshots in Files changed)Flow
Create an account or sign in
Go to /verify
Click Continue on verify/doc_auth/welcome
Check radio button and then Continue on /verify/doc_auth/agreement
Click upload from your computer on /verify/doc_auth/upload
Upload and Submit docs to fail ID verification
Click Try in person on /verify/doc_auth/document_capture
Enter any address in the input field and Search on /verify/doc_auth/document_capture#location
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before: There was an internal error processing your request. Please try again.
After: We are having technical difficulties at the moment. Try searching for a Post Office again. If this issue continues, come back later.