Skip to content

LG-9097 document capture show outside FSM#7926

Merged
soniaconnolly merged 4 commits intomainfrom
sonia-lg-9097-document-capture-show
Mar 7, 2023
Merged

LG-9097 document capture show outside FSM#7926
soniaconnolly merged 4 commits intomainfrom
sonia-lg-9097-document-capture-show

Conversation

@soniaconnolly
Copy link
Copy Markdown
Contributor

🎫 Ticket

LG-9097

🛠 Summary of changes

Add DocumentCaptureController that shows same view as DocumentCapture step for desktop flow, with supporting controller and feature tests. Functionality is behind feature flag doc_auth_document_capture_controller_enabled, which defaults to false.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Create an account
  • Navigate to /verify
  • Choose desktop flow
  • At document capture step, navigate to /verify/document_capture (no doc_auth)
  • Confirm that view has all the correct components and upload links are operational via javascript

👀 Screenshots

After:

DocumentCapture after

eric-gade and others added 4 commits March 3, 2023 15:22
and make it pass

changelog: Internal, refactoring Flow State Machine, add new DocumentCaptureController with show action for desktop flow
@soniaconnolly soniaconnolly marked this pull request as ready for review March 6, 2023 16:14
@soniaconnolly soniaconnolly requested a review from a team March 6, 2023 16:15
Copy link
Copy Markdown
Contributor

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it doesn't seem like there is any checking about the previous steps being completed (when the feature flag is enabled).

Here is what I did -- all local dev:

  1. Created a new account
  2. went to localhost:3000/verify and loaded that page
  3. Manually changed the url to /verify/document_capture

I was able to see the document capture page in that case, which I didn't expect. I thought I would be thrown back to the beginning of the doc auth flow since I had not yet completed any of the previous steps.

Ignore this if that is part of the multi-PR rollout of the ticket.

current_flow_step_counts['Idv::Steps::DocumentCaptureStep'] += 1
end

def native_camera_ab_testing_variables
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not immediately relevant, but we should ask if we still even need this a/b test anymore

@soniaconnolly
Copy link
Copy Markdown
Contributor Author

Right now it doesn't seem like there is any checking about the previous steps being completed (when the feature flag is enabled).

Let's check during refinement whether that should be part of this ticket. Thanks!

@soniaconnolly
Copy link
Copy Markdown
Contributor Author

@eric-gade Updating from refinement, we're adding an AC about checking if previous steps were completed to the next ticket. Good catch.

Copy link
Copy Markdown
Contributor

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soniaconnolly soniaconnolly merged commit 5b6d7a8 into main Mar 7, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-9097-document-capture-show branch March 7, 2023 17:59
@jmdembe jmdembe mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants