Skip to content

Added doc on how to fix OpenSSL error in tests#7925

Merged
jmax-gsa merged 4 commits intomainfrom
friday-test-hacking/fix-ssl-dynamic-linking-error
Mar 6, 2023
Merged

Added doc on how to fix OpenSSL error in tests#7925
jmax-gsa merged 4 commits intomainfrom
friday-test-hacking/fix-ssl-dynamic-linking-error

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Mar 3, 2023

We found a procedure which fixes an occasional problem in our test suite. Sometimes, for no obvious reason, a developer's machine will start throwing this error:

     Failure/Error: JWT::JWK.import(certs_response[:keys].first).public_key
     OpenSSL::PKey::PKeyError:
       rsa#set_key= is incompatible with OpenSSL 3.0

on the test file spec/features/openid_connect/openid_connect_spec.rb

This PR add documentation on how to correct the problem.

@jmax-gsa jmax-gsa force-pushed the friday-test-hacking/fix-ssl-dynamic-linking-error branch from c59845c to 1195e27 Compare March 3, 2023 20:08
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of editorial suggestions, overall looks great and thanks for putting this together!

@@ -0,0 +1,57 @@
# This document describes a recurrent problem with OpenSSL and some of our tests
The problem appears to manifests when Ruby was built and linked against
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The problem appears to manifests when Ruby was built and linked against
The problem arises when Ruby was built and linked against

And re-install, using the correct OpenSSL installation:
`RUBY_CONFIGURE_OPTS="--with-openssl-dir=$(brew --prefix openssl@1.1)" asdf install ruby 3.2.0`

## Rebuilding Ruby using ruby-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Rebuilding Ruby using ruby-build
## Rebuilding Ruby using ruby-build (all other version managers)

jmax-gsa and others added 3 commits March 6, 2023 11:05
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
@jmax-gsa jmax-gsa marked this pull request as ready for review March 6, 2023 17:04
@jmax-gsa jmax-gsa merged commit f1869b4 into main Mar 6, 2023
@jmax-gsa jmax-gsa deleted the friday-test-hacking/fix-ssl-dynamic-linking-error branch March 6, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants