Merged
Conversation
We recently consolidated the OTP delivery method controller and the phone controller in IdV. The old OTP delivery method controller is no more. I found a redirect to it and discovered it was still referenced in the routes. This commit cleans up both of those and removes an unused shared example I found in the process. changelog: Internal, Code cleanup, The following were removed: A redirect to an unused route; tests that tested the redirect to the unused route; a RSpec shared example that included a reference to this unused route but was not actually used in any specs.
jmhooper
deleted the
jmhooper-remove-leftover-otp-delivery-method-redirect
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently consolidated the OTP delivery method controller and the phone controller in IdV. The old OTP delivery method controller is no more. I found a redirect to it and discovered it was still referenced in the routes. This commit cleans up both of those and removes an unused shared example I found in the process.