Skip to content

LG-8580 Remove unsupported inherited proofing code#7919

Merged
jmhooper merged 3 commits intomainfrom
jmhooper-retire-inheritted-proofing
Mar 3, 2023
Merged

LG-8580 Remove unsupported inherited proofing code#7919
jmhooper merged 3 commits intomainfrom
jmhooper-retire-inheritted-proofing

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Mar 3, 2023

We built out the inherited proofing experience, but it is not currently enabled or supported. This commit removes it.

We built out the inheritted proofing experience, but it is not currently enabled or supported. This commit removes it.

changelog: Improvement, Inheritted proofing, The code for inheritted proofing was removed.
@aduth
Copy link
Contributor

aduth commented Mar 3, 2023

Should we remove scripts/va-api-test.rb ?

@jmhooper
Copy link
Contributor Author

jmhooper commented Mar 3, 2023

Should we remove scripts/va-api-test.rb ?

I wasn't sure.... but it'll be in history so i actually i will go ahead and pull it out.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


<div class='margin-y-4 text-center'>
<%= image_tag(
asset_url('shield-spinner.gif'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is now unused and can be removed.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit c9cd8f3 into main Mar 3, 2023
@jmhooper jmhooper deleted the jmhooper-retire-inheritted-proofing branch March 3, 2023 18:50
@jmdembe jmdembe mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants