Conversation
|
Questions on this:
|
There was a problem hiding this comment.
should this be a fieldsetor legend instead? see https://dequeuniversity.com/rules/axe/2.0/radiogroup?application=axeAPI
app/views/idv/sessions/new.html.slim
Outdated
There was a problem hiding this comment.
there is no label-ssn id on the page, so this is an invalid aria-labelledby attr
**Why**: * 508 compliance * For radio buttons, was getting error: "Radio inputs with the same name attribute value must be part of a group" * Ref: https://dequeuniversity.com/rules/axe/2.0/radiogroup * For other form, there was an invalid aria attr (did not correspond to an `id` in the markup)
jessieay
force-pushed
the
jy-more-508
branch
from
0109df0 to
665bb74
Compare
| .sm-right-align { text-align: right; } | ||
| } | ||
|
|
||
| .sr-only { |
There was a problem hiding this comment.
I added this per recs in https://snook.ca/archives/html_and_css/hiding-content-for-accessibility
is this the best place to put this? cc @brendansudol
There was a problem hiding this comment.
@jessieay basscss already has a similar class - checkout accessible hide here: http://basscss.com/#basscss-hide
There was a problem hiding this comment.
You are correct! I assumed hide was not accessible but that was not a good assumption.
Screenshot of the CSS that hide generates:
**Why**: Hide is accessible!
|
@hursey013 updated at 2f1cece |
|
@hursey013 re-review? |
**Why**: * 508 compliance * For radio buttons, was getting error: "Radio inputs with the same name attribute value must be part of a group" * Ref: https://dequeuniversity.com/rules/axe/2.0/radiogroup * For other form, there was an invalid aria attr (did not correspond to an `id` in the markup)
**Why**: * 508 compliance * For radio buttons, was getting error: "Radio inputs with the same name attribute value must be part of a group" * Ref: https://dequeuniversity.com/rules/axe/2.0/radiogroup * For other form, there was an invalid aria attr (did not correspond to an `id` in the markup)
3 participants
Why:
"Radio inputs with the same name attribute value must be part of a
group"
to an
idin the markup)