Merged
Conversation
…d_phone method in view data
aduth
approved these changes
Feb 24, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍
Looks like this might have been erroneously removed in #7868 (cc @mitchellhenke in case there's other context / potential follow-ons)
Contributor
|
Whoops, it didn't look like it was used, but I missed this. Thanks for catching it. |
zachmargolis
approved these changes
Feb 24, 2023
Contributor
|
Did the breaking change make it into prod? Do we we need to patch release this in? |
Contributor
Author
yes actually |
aduth
pushed a commit
that referenced
this pull request
Feb 24, 2023
…d_phone method in view data (#7884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9037: Unconfirmed Phone fix