Jmax/lg 8889 best effort parsing of aamva exceptions#7879
Conversation
jmax-gsa
force-pushed
the
jmax/LG-8889-best-effort-parsing-of-aamva-exceptions
branch
from
5aa5065 to
1368401
Compare
| applicant: applicant, | ||
| session_id: '1234-abcd-efgh', | ||
| ) | ||
| describe '#send_verification_request' do |
There was a problem hiding this comment.
This describe block looks like it is describing the same method as the block above
There was a problem hiding this comment.
It is, but a different aspect of the method. The setup code was different enough to warrant splitting the describe block.
|
|
||
| it 'parses the raw response body' do | ||
| begin | ||
| response |
There was a problem hiding this comment.
I'm not sure I follow what this test is trying to accomplish? It looks like the test below covers what we actually care about.
There was a problem hiding this comment.
An explicit test that we tried to parse the body.
|
It looks like we aren't covering a case that we are concerned about in the tests. That is when we have the MVA timeout which will have a 500 response and a response body that we should be able to use the SOAP fault response fixture to put together. |
Removed explict checks for calls to REXML methods; it is enough to make sure we get the correct information out of the XML when it's available.
One more REXML spec removed.
jmax-gsa
deleted the
jmax/LG-8889-best-effort-parsing-of-aamva-exceptions
branch
3 participants
No description provided.