Remove email address from verification page for authention apps#7876
Merged
mitchellhenke merged 4 commits intomainfrom Feb 27, 2023
Merged
Remove email address from verification page for authention apps#7876mitchellhenke merged 4 commits intomainfrom
mitchellhenke merged 4 commits intomainfrom
Conversation
mdiarra3
approved these changes
Feb 23, 2023
aduth
approved these changes
Feb 23, 2023
aduth
reviewed
Feb 23, 2023
added 2 commits
February 24, 2023 10:40
changelog: Improvements, Authentication Apps, Remove email address from verification page
mitchellhenke
force-pushed
the
mitchellhenke/auth-app-no-email
branch
from
531974f to
9f1dd30
Compare
aduth
approved these changes
Feb 24, 2023
mitchellhenke
changed the title
mitchellhenke
force-pushed
the
mitchellhenke/auth-app-no-email
branch
2 times, most recently
from
3fb5389 to
3c26dab
Compare
mitchellhenke
force-pushed
the
mitchellhenke/auth-app-no-email
branch
from
3c26dab to
0159652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Following the work in #7868 and #7869 and a brief discussion in Slack, this PR removes the email from the TOTP QR code provisioning URI and the verification page.
The provisioning URI is not quite reliable, as not all authentication apps were able to process it, and it sometimes resulted in showing only the email address without any mention of Login.gov. Accounts can have multiple email addresses and email addresses may change, so the email address that the authentication app was provisioned with may not match the email displayed on the verification page.