Skip to content

Removed analytics check from password visibility toggle spec. #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmax-gsa merged 1 commit into from
Feb 21, 2023
Merged

Removed analytics check from password visibility toggle spec. #7860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions spec/features/users/sign_in_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,22 +220,10 @@
end

scenario 'user can see and use password visibility toggle', js: true do
fake_analytics = FakeAnalytics.new
allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)

visit new_user_session_path

check t('components.password_toggle.toggle_label')

# Clicking the checkbox triggers a frontend event logging request. Wait for network requests to
# settle before continuing to avoid a race condition.
Capybara.current_session.server.wait_for_pending_requests

expect(page).to have_css('input.password[type="text"]')
expect(fake_analytics).to have_logged_event(
'Show Password Button Clicked',
path: new_user_session_path,
)
end

scenario 'user session expires in amount of time specified by Devise config' do
Expand Down