LG-8215 Update Event: IDV Reproof using Address verify by Mail

app/controllers/idv/review_controller.rb

@@ -53,8 +53,6 @@ def create
 
       init_profile
 
-      log_reproof_event if idv_session.profile.has_proofed_before?
-
       user_session[:need_personal_key_confirmation] = true
 
       redirect_to next_step
@@ -78,10 +76,6 @@ def address_verification_method
       user_session.dig('idv', 'address_verification_mechanism')
     end
 
-    def log_reproof_event
-      irs_attempts_api_tracker.idv_reproof
-    end
-
     def flash_message_content
       if idv_session.address_verification_mechanism != 'gpo'
         phone_of_record_msg = ActionController::Base.helpers.content_tag(

app/controllers/sign_up/completions_controller.rb

@@ -83,6 +83,7 @@ def analytics_attributes(page_occurence)
     end
 
     def track_completion_event(last_page)
+      irs_attempts_api_tracker.idv_reproof if current_user.profiles&.last&.has_proofed_before?
       analytics.user_registration_complete(**analytics_attributes(last_page))
     end
 

spec/controllers/idv/review_controller_spec.rb

@@ -371,24 +371,6 @@ def show
           expect(disavowal_event_count).to eq 1
         end
 
-        context 'when the user goes through reproofing' do
-          it 'does not log a reproofing event during initial proofing' do
-            put :create, params: { user: { password: ControllerHelper::VALID_PASSWORD } }
-
-            expect(@irs_attempts_api_tracker).not_to receive(:idv_reproof)
-          end
-
-          it 'logs a reproofing event upon reproofing' do
-            put :create, params: { user: { password: ControllerHelper::VALID_PASSWORD } }
-
-            idv_session.profile.update(verified_at: nil)
-
-            expect(@irs_attempts_api_tracker).to receive(:idv_reproof)
-
-            put :create, params: { user: { password: ControllerHelper::VALID_PASSWORD } }
-          end
-        end
-
         context 'with in person profile' do
           let!(:enrollment) do
             create(:in_person_enrollment, :establishing, user: user, profile: nil)

spec/controllers/sign_up/completions_controller_spec.rb

@@ -270,5 +270,37 @@
         end
       end
     end
+
+    context 'when the user goes through reproofing' do
+      let!(:user) { create(:user, profiles: [create(:profile, :active)]) }
+
+      before do
+        stub_attempts_tracker
+        allow(@irs_attempts_api_tracker).to receive(:track_event)
+      end
+
+      it 'does not log a reproofing event during initial proofing' do
+        stub_sign_in(user)
+        subject.session[:sp] = {
+          ial2: false,
+          issuer: 'foo',
+          request_url: 'http://example.com',
+        }
+        expect(@irs_attempts_api_tracker).not_to receive(:idv_reproof)
+        patch :update
+      end
+
+      it 'logs a reproofing event upon reproofing' do
+        user.profiles.create(verified_at: Time.zone.now, active: true, activated_at: Time.zone.now)
+        stub_sign_in(user)
+        subject.session[:sp] = {
+          ial2: false,
+          issuer: 'foo',
+          request_url: 'http://example.com',
+        }
+        expect(@irs_attempts_api_tracker).to receive(:idv_reproof)
+        patch :update
+      end
+    end
   end
 end