-
Notifications
You must be signed in to change notification settings - Fork 167
LG-8901: New Hybrid Handoff (upload step) with feature flag #7849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a4cd9d2
c52ee19
56a7007
c1d71ab
84525ac
17e18d8
f1a92ac
973e2a3
18fbc0f
027bccb
eb41f8c
912681e
b6b7992
a08b253
512907f
fbfa4d3
f1bbb48
b67f3e5
43ff1d5
c79df80
9d2782e
22ee1f2
fc84259
441cb93
0f83be7
03533d8
f1c48c7
b09792f
01783a6
30a02c2
9bee92c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,74 @@ | ||||||
| <% title t('titles.doc_auth.upload') %> | ||||||
|
|
||||||
| <%= render 'idv/doc_auth/error_messages', flow_session: flow_session %> | ||||||
|
|
||||||
| <%= render PageHeadingComponent.new do %> | ||||||
| <%= t('doc_auth.headings.combined_upload') %> | ||||||
| <% end %> | ||||||
|
|
||||||
| <p> | ||||||
| <%= t('doc_auth.info.combined_upload') %> | ||||||
| </p> | ||||||
|
|
||||||
| <div class="grid-row grid-gap grid-gap-1"> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From the design reference, it looks like the gap should be 1rem, which would be 2 units in the design system.
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||||||
| <div class="grid-col-12 tablet:grid-col-auto"> | ||||||
| <%= image_tag( | ||||||
| asset_url('idv/phone-icon.svg'), | ||||||
| alt: t('image_description.camera_mobile_phone'), | ||||||
| width: 88, | ||||||
| height: 88, | ||||||
| ) %> | ||||||
| </div> | ||||||
| <div class="grid-col-12 tablet:grid-col-fill"> | ||||||
| <div class="usa-tag usa-tag--informative"> | ||||||
| <%= t('doc_auth.info.tag') %> | ||||||
| </div> | ||||||
| <h2 class="margin-y-105"> | ||||||
| <%= t('doc_auth.headings.combined_upload_from_phone') %> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the future, maybe we circle back to unqualify these as "combined", since once the feature is enabled and the feature flag removed, I don't think we need to consider this as anything other than the default text for the screen.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah that was the plan. Anything with "combined" will be renamed, including querystring params. |
||||||
| </h2> | ||||||
| <%= t('doc_auth.info.combined_upload_from_phone') %> | ||||||
| <%= simple_form_for( | ||||||
| idv_phone_form, | ||||||
| as: :doc_auth, | ||||||
| url: url_for(type: :mobile, combined: true), | ||||||
| method: 'PUT', | ||||||
| html: { autocomplete: 'off' }, | ||||||
| ) do |f| %> | ||||||
| <%= render PhoneInputComponent.new( | ||||||
| form: f, | ||||||
| required: true, | ||||||
| delivery_methods: [:sms], | ||||||
| class: 'margin-bottom-4', | ||||||
| ) %> | ||||||
| <%= f.submit t('forms.buttons.send_link') %> | ||||||
| <% end %> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| <hr class="margin-y-4" /> | ||||||
| <div class="grid-row grid-gap grid-gap-2"> | ||||||
| <div class="grid-col-12 tablet:grid-col-auto"> | ||||||
| <%= image_tag( | ||||||
| asset_url('idv/laptop-icon.svg'), | ||||||
| alt: t('image_description.laptop'), | ||||||
| width: 88, | ||||||
| height: 88, | ||||||
| ) %> | ||||||
| </div> | ||||||
| <div class="grid-col-12 tablet:grid-col-fill"> | ||||||
| <h2 class="margin-y-105"> | ||||||
| <%= t('doc_auth.headings.combined_upload_from_computer') %> | ||||||
| </h2> | ||||||
| <%= t('doc_auth.info.combined_upload_from_computer') %> | ||||||
| <%= simple_form_for( | ||||||
| :doc_auth, | ||||||
| url: url_for(type: :desktop), | ||||||
| method: 'PUT', | ||||||
| class: 'margin-bottom-4', | ||||||
| ) do |f| %> | ||||||
| <%= f.submit t('forms.buttons.upload_photos'), outline: true %> | ||||||
| <% end %> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| <%= render 'idv/doc_auth/cancel', step: 'upload' %> | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <% title t('titles.doc_auth.upload') %> | ||
|
|
||
| <%= render 'idv/doc_auth/error_messages', flow_session: flow_session %> | ||
|
|
||
| <%= render PageHeadingComponent.new do %> | ||
| <%= t('doc_auth.headings.upload') %> | ||
| <% end %> | ||
|
|
||
| <p> | ||
| <%= t('doc_auth.info.upload') %> | ||
| </p> | ||
|
|
||
| <hr class="margin-y-4" /> | ||
|
|
||
| <div class="grid-row"> | ||
| <div class="grid-col-12 tablet:grid-col-3"> | ||
| <%= image_tag( | ||
| asset_url('idv/phone.png'), | ||
| alt: t('image_description.camera_mobile_phone'), | ||
| width: 80, | ||
| height: 119, | ||
| ) %> | ||
| </div> | ||
| <div class="grid-col-12 tablet:grid-col-9"> | ||
| <div class="usa-tag text-ink bg-primary-lighter margin-top-1"> | ||
| <%= t('doc_auth.info.tag') %> | ||
| </div> | ||
| <h2 class="margin-y-105"> | ||
| <%= t('doc_auth.headings.upload_from_phone') %> | ||
| </h2> | ||
| <%= t('doc_auth.info.upload_from_phone') %> | ||
| <%= simple_form_for( | ||
| :doc_auth, | ||
| url: url_for(type: :mobile), | ||
| method: 'PUT', | ||
| html: { autocomplete: 'off', class: 'margin-top-2' }, | ||
| ) do |f| %> | ||
| <%= f.submit t('doc_auth.buttons.use_phone'), wide: false, class: 'margin-top-05' %> | ||
| <% end %> | ||
| </div> | ||
| </div> | ||
|
|
||
| <hr class="margin-y-4" /> | ||
|
|
||
| <%= t('doc_auth.info.upload_from_computer') %> | ||
| <%= simple_form_for( | ||
| :doc_auth, | ||
| url: url_for(type: :desktop), | ||
| method: 'PUT', | ||
| html: { class: 'display-inline' }, | ||
| ) do |f| %> | ||
| <%= f.submit t('doc_auth.info.upload_computer_link'), unstyled: true, big: false %> | ||
| <% end %> | ||
|
|
||
| <%= render 'idv/doc_auth/cancel', step: 'upload' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recognizing there's a lot of legacy here being copied verbatim, I still want to flag that it's a bit problematic how we assume phone numbers are U.S., especially since
PhoneInputComponentwill provide us with ainternational_codeparameter we can plug in here. I suspect this is a hold-over logic from previous implementation where the phone input was a plain input field.