Merged
Conversation
changelog: Internal, Console, Disable autocompleting in Rails console
zachmargolis
approved these changes
Feb 7, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, we could also add a gitignore to be safe?
aduth
changed the title
mitchellhenke
approved these changes
Feb 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates theSaving history is not gitignore'd, so could be accidentally committed, and risks the chance that history contains sensitive information. Alternatively, we could gitignore, though I'm not sure that having history provides much value anyways..irbrcconfiguration added in #7770 to avoidirbsaving history, which is the default behavior.Edit: Per discussion at #7783 (comment), we're keeping the default history behavior, but adding the history file to
.gitignore(the "alternatively" option mentioned above).📜 Testing Plan
irb1+1).irb_historyfile in project root directory