SpinnerButton: Clear timeout on disconnect#7779
Merged
Conversation
The open timeout was causing test runner not to terminate cleanly
changelog: Internal, Automated Testing, Improve reliability of JavaScript tests
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Extracted from #7761, related to LG-8771.
🛠 Summary of changes
Implements a
disconnectedCallbackfor theSpinnerButtonElementto ensure that the scheduled timeout handling for the "long delay" action message is removed.I discovered in #7761 that this is causing the test process to hang open long after tests have finished (up to 20 seconds), likely due to the fact that the process is waiting for pending timeouts. It's a good practice for the component to clean up after itself when removed anyways, even though in the real world this would usually only happen when the user moves from one page to another.
📜 Testing Plan
yarn test