Merged
Conversation
Check cipher name by calling library, because names can change. Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
[skip changelog] Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
zachmargolis
reviewed
Feb 3, 2023
Comment on lines
10
to
12
|
|
||
| class ExampleAnalytics < FakeAnalytics | ||
| class ExampleAnalyticsForFL < FakeAnalytics | ||
| include ExampleAnalyticsEvents | ||
| end |
Contributor
There was a problem hiding this comment.
ooo I have thoughts about this, I like to create anonymous classes so we don't have to worry about these collisions:
let(:analytics_class) do
Class.new(FakeAnalytics) do
include ExampleAnalyticsEvents
end
end
let(:analytics) { analytics_class.new }
jmax-gsa
approved these changes
Feb 3, 2023
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
LGTM
The change to using classes created on the fly cleans this up even more; nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fix two services tests that failed when the whole services test suite was run locally