LG-8834 add phone to ready to verify email#7767
Merged
svalexander merged 3 commits intomainfrom Feb 3, 2023
Merged
Conversation
Contributor
|
@svalexander This looks good, could you please add a test? Thanks! |
eileen-nava
approved these changes
Feb 3, 2023
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Once the build passes, I think this is good to merge.
svalexander
changed the title
svalexander
deleted the
shannon/lg-8834-add-phone-to-ready-to-verify-email
branch
aduth
reviewed
Feb 3, 2023
| </div> | ||
| <div> | ||
| <%= @presenter.selected_location_details[:phone] %> | ||
| <%= @presenter.selected_location_details['phone'] %> |
Contributor
There was a problem hiding this comment.
I've seen we've had a few similar instances of this sort of problem since it was introduced. I wonder if we could make this hash a HashWithIndifferentAccess so that it would support keys referenced either as strings or as symbols. It's complicated by the fact that this is a database field, but maybe it's possible to override the method on the InPersonEnrollment class?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Lg-8834
🛠 Summary of changes
Get phone from selected_location_details so that it is included in ready to verify email
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: