[LG-6146] Remove ERB processing when reading service_providers.yml#7764
Merged
mitchellhenke merged 1 commit intomainfrom May 30, 2023
Merged
[LG-6146] Remove ERB processing when reading service_providers.yml#7764mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
julialeague
reviewed
Feb 6, 2023
orenyk
force-pushed
the
oyk-env-specific-yaml
branch
from
5dbeeb3 to
b5bafe8
Compare
julialeague
approved these changes
Feb 7, 2023
orenyk
force-pushed
the
oyk-env-specific-yaml
branch
2 times, most recently
from
3ac0760 to
8ffb9fb
Compare
Contributor
|
Checking in on the status of old pull requests. Is this still being worked on, or can we close it? |
Contributor
|
Yep still being worked on, will be looking to finish this soon |
mitchellhenke
force-pushed
the
oyk-remove-erb
branch
from
48e692c to
3ea9a0e
Compare
Resolves LG-6146 changelog: Internal, Deployment, Remove ERB processing of configuration file
mitchellhenke
force-pushed
the
oyk-remove-erb
branch
from
3ea9a0e to
2e4baa3
Compare
mmagsa
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves LG-6146
changelog: Internal, Deployment, Remove ERB processing of configuration file
Follow-up to #7742, should only be merged after https://github.com/18F/identity-idp-config/pull/1256 is merged