-
Notifications
You must be signed in to change notification settings - Fork 166
LG-8577: Prefill user's mobile number for hybrid docauth #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c356de
LG-8577: Prefill mobile number for hybrid docauth
matthinz 5c61745
Update spec/features/idv/doc_auth/send_link_step_spec.rb
matthinz edc26d5
Update app/services/idv/steps/send_link_step.rb
matthinz 339abf0
create_form -> build_form
matthinz b683228
Fix line length issue
matthinz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -68,6 +68,16 @@ | |||||||||
| and_return(irs_attempts_api_tracker) | ||||||||||
| end | ||||||||||
|
|
||||||||||
| describe '#extra_view_variables' do | ||||||||||
| it 'includes form' do | ||||||||||
| expect(step.extra_view_variables).to include( | ||||||||||
| { | ||||||||||
| idv_phone_form: be_an_instance_of(Idv::PhoneForm), | ||||||||||
| }, | ||||||||||
|
Comment on lines
+74
to
+76
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically the curly braces could be optional, though I don't have a strong preference in case you think they help readability.
Suggested change
|
||||||||||
| ) | ||||||||||
| end | ||||||||||
| end | ||||||||||
|
|
||||||||||
| describe 'the return value from #call' do | ||||||||||
| let(:response) { step.call } | ||||||||||
|
|
||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to check: the only reason we're building the form is so we can pass it something that responds to
#phoneright? Could we pass a different object or like a simple PORO/Struct that has a#phonemethod?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based this usage on
Idv::PhoneControllerwhich also usesIdv::PhoneForm. The form has some logic already built into it to pre-fill the user's MFA phone number.