LG-8330: Allow user to select USPS location when search box is empty

[eileen-nava]

🎫 Ticket

8330: User cannot select an IPP location if search box is empty

🛠 Summary of changes

• User can now select a USPS location when the address search box is empty
• User can now proceed past the PO Search page when the address search box is empty

📜 Testing Plan

Happy Path

• Navigate to the PO Search page and search for a valid address
• After USPS locations load, delete the text from the search box
• Click the "select" button for a USPS location

Edge Cases
Run through the happy path, but then....

• Navigate back to the PO Search Page. Confirm you can select a different USPS location.
  Run through the happy path, but then....
• Navigate back to the PO Search Page. Confirm you can search for a different address and select a USPS location.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Feature In Action:

SelectLocationWithEmptySearchBox.mov

[allthesignals]

Interesting... how does this fix the issue? Does the FormSteps stuff ignore disabled fields even after invalidation?

[allthesignals]

@NavaTim I'm just curious — how does this work/fix the bug?

[JackRyan1989]

@allthesignals: I think this answers what you're asking, but please say so if I missed your q. @eileen-nava filled me in on the inner workings here. The form steps component is just a standard form element, so when you pass an attribute of 'disabled' to that form field, it does not validate that field. TIL: MDN Disabled Overview

[allthesignals]

Oh, great! I assumed FormSteps was doing validation... sounds like it's being done natively!

[NavaTim]

@allthesignals The ValidatedFieldElement hooks into the invalid event, which doesn't trigger when the element is disabled.

Relevant spec sections:

valid = element.checkValidity()
Returns true if the element's value has no validity problems; false otherwise. Fires an invalid event at the element in the latter case.

Source

Note that the invalid event in the above source is mentioned as being triggered by the constraint validation API.

Constraint validation: If an element is disabled, it is barred from constraint validation.

Source

A submittable element is a candidate for constraint validation except when a condition has barred the element from constraint validation. (For example, an element is barred from constraint validation if it is an object element.)

Source

[allthesignals]

Fascinating. Thank you Tim!

[NavaTim]

Overall PR looks good and like what we discussed, but would be good to add a test here to prevent regression.

[eileen-nava]

Overall PR looks good and like what we discussed, but would be good to add a test here to prevent regression.

Good point, I added a test.

[NavaTim]

Probably would move this and related prereq steps to the beforeEach, but it's not very important at the moment because we only have one it in this context.