Merged
Conversation
… is properly logged before a Rack Attack changelog: Internal, Attempts Api, Bugfix
n1zyy
approved these changes
Feb 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts Api, Bugfix
🎫 Ticket
Link to the relevant ticket.
LG-8705
🛠 Summary of changes
lower max_bad_passwords for the session_controller to a value that is under the Rack Attack value so that Attempts Api login_rate_limited event is properly logged before a Rack Attack.
This should also make security a bit more strict, and Rack Attack will still be in place to catch attackers if the session_controller rate limit is bypassed.