LG-8232 Update Event: IDV forget password email confirmed#7756
LG-8232 Update Event: IDV forget password email confirmed#7756olatifflexion merged 2 commits intomainfrom
Conversation
changelog: Internal, Attempts API, Passing request_id in the email link
| <center> | ||
| <%= link_to t('user_mailer.reset_password_instructions.link_text'), | ||
| edit_user_password_url(reset_password_token: @token, locale: @locale), | ||
| edit_user_password_url(reset_password_token: @token, locale: @locale, request_id: @request_id), |
There was a problem hiding this comment.
can you provide some background on what linking the request_id does here? does it keep some session around that we need for attempts API?
If so, can we add some sort of acceptance spec that maybe clicks one of these emails and sees the event linked correctly? or something that helps explain why?
There was a problem hiding this comment.
Yes! I added this (some other emails also pass request_id in URL and they are logging events) to keep some SP sessions.
Sure let me check I will try to add some tests.
There was a problem hiding this comment.
currently, events get logged when the user clicks the reset password link from the email within the same browser session, but if a user closes the browser and then clicks the reset password link from the email our system does not log the event for that reason I added request_id in the links.
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the specs!
2 participants
changelog: Internal, Attempts API, Passing request_id in the forget password email link