Skip to content

Revert "Lg-8328 table headers" #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Jan 30, 2023
Merged

Revert "Lg-8328 table headers" #7722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f69d451
Revert "Lg-8328 table headers (#7535)"
Jan 30, 2023
5bb233e
changelog: Internal, Email, Revert adding presentation role to email …
Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions app/views/layouts/user_mailer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</title>
</head>
<body>
<table class="body" data-made-with-foundation="" role="presentation">
<table class="body" data-made-with-foundation="">
<tbody>
<tr>
<td align="center" class="float-center" valign="top">
Expand All @@ -22,7 +22,7 @@
</tr>
</tbody>
</table>
<table class="container float-center" role="presentation">
<table class="container float-center">
<tbody>
<tr>
<td>
Expand All @@ -38,31 +38,31 @@
<table class="row">
<tbody>
<tr>
<td class="small-12 large-12 columns first last">
<table role="presentation">
<th class="small-12 large-12 columns first last">
<table>
<tr>
<td>
<th>
<%= image_tag(
attachments['logo.png'].url,
size: '142x19',
style: 'width: 142px; height: 19px;',
alt: t('mailer.logo', app_name: APP_NAME),
) %>
</td>
<td class="expander"></td>
</th>
<th class="expander"></th>
</tr>
</table>
</td>
</th>
</tr>
</tbody>
</table>
<table class="row">
<tbody>
<tr>
<td class="small-12 large-12 columns first last">
<th class="small-12 large-12 columns first last">
<table>
<tr>
<td>
<th>
<table class="spacer">
<tbody>
<tr>
Expand All @@ -86,10 +86,10 @@
</tr>
</tbody>
</table>
</td>
</th>
</tr>
</table>
</td>
</th>
</tr>
</tbody>
</table>
Expand All @@ -99,10 +99,10 @@
<table class="row">
<tbody>
<tr>
<td class="small-12 large-12 columns first last">
<th class="small-12 large-12 columns first last">
<table>
<tr>
<td>
<th>
<p>
<%= (t('mailer.no_reply') + ' ' + t(
'mailer.help',
Expand All @@ -112,10 +112,10 @@
),
)).html_safe %>
</p>
</td>
</th>
</tr>
</table>
</td>
</th>
</tr>
</tbody>
</table>
Expand All @@ -128,17 +128,17 @@
<table class="row">
<tbody>
<tr>
<td class="small-12 large-12 columns first last">
<th class="small-12 large-12 columns first last">
<table class="hr">
<tr>
<th>
&nbsp;
</th>
</tr>
</table>
<table role="presentation">
<table>
<tr>
<td>
<th>
<p>
<%= link_to(
t('mailer.about', app_name: APP_NAME),
Expand All @@ -152,11 +152,11 @@
style: 'text-decoration: underline;',
).html_safe %>
</p>
</td>
<td class="expander"></td>
</th>
<th class="expander"></th>
</tr>
</table>
</td>
</th>
</tr>
</tbody>
</table>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/account_reset_granted.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= t('user_mailer.account_reset_granted.intro_html', app_name: link_to(APP_NAME, IdentityConfig.store.mailer_domain_name, class: 'gray')) %>
</p>

<table class="button expanded large" role="presentation">
<table class="button expanded large">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/add_email.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= t('user_mailer.add_email.footer', confirmation_period: @confirmation_period) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/add_email_associated_with_another_account.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/email_confirmation_instructions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= t('user_mailer.email_confirmation_instructions.footer', confirmation_period: @confirmation_period) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/in_person_completion_survey.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</p>
<p class="margin-bottom-4"><%= t('user_mailer.in_person_completion_survey.body.cta.callout') %></p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/in_person_deadline_passed.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
%>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
8 changes: 4 additions & 4 deletions app/views/user_mailer/reset_password_instructions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% if @pending_profile_requires_verification %>
<table role="presentation">
<table>
<tbody>
<tr>
<td width="140">
Expand All @@ -23,7 +23,7 @@
) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down Expand Up @@ -67,8 +67,8 @@
<tr>
<th>
&nbsp;
</th>
</tr>
</tr>
</th>
</table>

<p>
Expand Down
4 changes: 2 additions & 2 deletions app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<table class="info-alert margin-y-4" role="presentation">
<table class="info-alert margin-y-4">
<tr>
<td width="16">
<%= image_tag('email/info.png', width: 16, height: 16, alt: '') %>
Expand All @@ -15,7 +15,7 @@
<%= t('in_person_proofing.body.barcode.items_to_bring') %>
</h2>
<p><%= t('in_person_proofing.body.barcode.speak_to_associate') %></p>
<table class="process-list" role="presentation">
<table class="process-list">
<tr>
<td><div class="process-list__circle">1</div></td>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/signup_with_your_email.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<%= t('user_mailer.signup_with_your_email.intro_html', app_name: link_to(APP_NAME, IdentityConfig.store.mailer_domain_name, class: 'gray')) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/user_mailer/unconfirmed_email_instructions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<%= t('user_mailer.email_confirmation_instructions.request_with_diff_email', app_name: APP_NAME) %>
</p>

<table class="button expanded large radius" role="presentation">
<table class="button expanded large radius">
<tbody>
<tr>
<td>
Expand Down