LG-8284: Make GetUspsProofingResultsJob terminate gracefully#7692
Closed
tomas-nava wants to merge 11 commits intomainfrom
Closed
LG-8284: Make GetUspsProofingResultsJob terminate gracefully#7692tomas-nava wants to merge 11 commits intomainfrom
tomas-nava wants to merge 11 commits intomainfrom
Conversation
added 4 commits
January 24, 2023 11:15
changelog: Internal, In-person proofing, Log progress when GetUspsProofingResultsJob is terminated
sheldon-b
approved these changes
Jan 27, 2023
Contributor
sheldon-b
left a comment
sheldon-b
left a comment
There was a problem hiding this comment.
Looks good! Have you tested this in practice, in a lower environment? I want to know that it works as expected since when I wrote the ticket it was just based on reading documentation
…ps-proofing-job-terminate-gracefully
Contributor
Author
Doing this now |
added 3 commits
February 13, 2023 10:48
…ps-proofing-job-terminate-gracefully
…ps-proofing-job-terminate-gracefully
…ps-proofing-job-terminate-gracefully
Contributor
Author
|
I'm closing this pull request, as |
tomas-nava
deleted the
tomas/lg-8284-make-usps-proofing-job-terminate-gracefully
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8284
🛠 Summary of changes
Logs progress when the
GetUspsProofingResultsJobis terminated by aConcurrencyExceededError.Note: I refactored the job to make it easier to implement this change; that refactoring happens in the first three commits. Functionality changes are in the last four commits.
📜 Testing Plan
The Joy environment already has many enrollments in the 'cancelled' status. If those enrollments are changed to 'pending' status, the concurrency limit is set to 1, and the GetUspsProofingResultsJob chron schedule is set to 5 minutes we should see jobs getting terminated frequently.