LG-8514: Log a more descriptive location search error#7675
Closed
tomas-nava wants to merge 1 commit intomainfrom
Closed
LG-8514: Log a more descriptive location search error#7675tomas-nava wants to merge 1 commit intomainfrom
tomas-nava wants to merge 1 commit intomainfrom
Conversation
changelog: Internal, In-person proofing, More descriptive error logging
zachmargolis
approved these changes
Jan 21, 2023
Comment on lines
+31
to
+35
| { | ||
| error_name: error.class.name, | ||
| message: error.message, | ||
| source: self.class.name, | ||
| }.to_json, |
Contributor
There was a problem hiding this comment.
I'd also add a descriptive key/event name so we can have something to find these by (not sure it's the best name, but the general idea)
Suggested change
| { | |
| error_name: error.class.name, | |
| message: error.message, | |
| source: self.class.name, | |
| }.to_json, | |
| { | |
| warning: "UspsLocationsController#index argcis" | |
| error_name: error.class.name, | |
| message: error.message, | |
| source: self.class.name, | |
| }.to_json, |
Contributor
|
Added simple testing plan for this — @tomas-nava ready to merge? happy to to test this out once deployed. |
allthesignals
approved these changes
Jan 23, 2023
Contributor
Author
|
I'm going to close this because it was made obsolete by #7695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
related to LG-8514
🛠 Summary of changes
Logs a more descriptive error when encountered during IPP location search.
📜 Testing Plan
Jay St & Water Street, Brooklyn, NY