Fully remove references to old ThreatMetrix config flags (LG-8512)#7639
Merged
Fully remove references to old ThreatMetrix config flags (LG-8512)#7639
Conversation
Contributor
|
Since this is a follow-on to #7582, could we switch the base of this PR to be |
solipet
approved these changes
Jan 12, 2023
zachmargolis
approved these changes
Jan 12, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM thanks for changing the base!
Remove references to old feature flags, which should be removed from environments by this point [skip changelog]
matthinz
force-pushed
the
matthinz/8512-followup
branch
from
5aaaa26 to
c1236b7
Compare
jmhooper
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #7582. Do not merge until environments have been appropriately configured.
How to configure an environment:
Remove the following configuration keys:
lexisnexis_threatmetrix_enabledlexisnexis_threatmetrix_required_to_verifyproofing_device_profiling_collecting_enabledproofing_device_profiling_decisioning_enabled(should not be present, but just in case)Add a new configuration key,
proofing_device_profiling, set to one ofdisabled,collect_only, orenabled.