Handle malformed payloads in sessions controller#7611
Merged
zachmargolis merged 5 commits intomainfrom Jan 11, 2023
Merged
Conversation
Error messages like > param is missing or the value is empty: #permit called on String [skip changelog]
mitchellhenke
approved these changes
Jan 10, 2023
Contributor
Author
|
Update: after some digging, the error thrown was entirely of our own creation in #2648, to work around a Devise bug. I think that Devise bug no longer exists because reverting the patch, but keeping a regression spec, the controllers do not throw errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages like
Example NR error, we had a few hundred of these in the last day