Improve email encryption error checking#759
Merged
Conversation
pkarman
commented
Nov 22, 2016
db/schema.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
it will be problematic to create new accounts while this schema is in force, so we should do a subsequent drop of this column as soon as possible after verifying that the migration was successful (via manual testing of login, etc).
Contributor
There was a problem hiding this comment.
let's make it nullable?
Merged
pkarman
force-pushed
the
pek-fix-encrypted-email
branch
from
6a1bd01 to
e7243be
Compare
Contributor
There was a problem hiding this comment.
Might need to quote/escape this?
escaped = ActiveRecord::Base.connection.quote(ee.decrypted)
execute "UPDATE users SET email=#{escaped} WHERE id=#{user.id}"
e7243be to
8581570
Compare
**Why**: Strengthen the error checking to better identify issues deciphering broken payloads.
pkarman
force-pushed
the
pek-fix-encrypted-email
branch
from
8581570 to
ab7aaca
Compare
**Why**: To help with migrations, rename the email column instead of dropping. The actual drop will happen in a future PR.
pkarman
force-pushed
the
pek-fix-encrypted-email
branch
from
ab7aaca to
72e80fb
Compare
zachmargolis
approved these changes
Nov 22, 2016
amoose
pushed a commit
that referenced
this pull request
Dec 1, 2016
* Refactor cipher error checking **Why**: Strengthen the error checking to better identify issues deciphering broken payloads. * Rename users.email instead of dropping **Why**: To help with migrations, rename the email column instead of dropping. The actual drop will happen in a future PR.
amoose
pushed a commit
that referenced
this pull request
Dec 1, 2016
* Refactor cipher error checking **Why**: Strengthen the error checking to better identify issues deciphering broken payloads. * Rename users.email instead of dropping **Why**: To help with migrations, rename the email column instead of dropping. The actual drop will happen in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Misconfiguration on deploy can erase existing email addresses forever.
How: Take a more conservative approach by renaming the plain text column for now.