Merge duplicate TM feature flags

app/controllers/idv/gpo_verify_controller.rb

@@ -101,7 +101,7 @@ def confirm_verification_needed
     end
 
     def threatmetrix_enabled?
-      IdentityConfig.store.proofing_device_profiling_decisioning_enabled
+      IdentityConfig.store.lexisnexis_threatmetrix_required_to_verify
     end
   end
 end

app/controllers/idv/personal_key_controller.rb

@@ -85,7 +85,7 @@ def pending_profile?
     end
 
     def blocked_by_device_profiling?
-      return false unless IdentityConfig.store.proofing_device_profiling_decisioning_enabled
+      return false unless IdentityConfig.store.lexisnexis_threatmetrix_required_to_verify
       proofing_component = ProofingComponent.find_by(user: current_user)
       # pass users who are inbetween feature flag being enabled and have not had a check run.
       return false if proofing_component.threatmetrix_review_status.nil?

config/application.yml.default

@@ -234,7 +234,6 @@ platform_auth_set_up_enabled: false
 poll_rate_for_verify_in_seconds: 3
 proofer_mock_fallback: true
 proofing_device_profiling_collecting_enabled: true
-proofing_device_profiling_decisioning_enabled: false
 proof_address_max_attempts: 5
 proof_address_max_attempt_window_in_minutes: 360
 proof_ssn_max_attempts: 10

lib/identity_config.rb

@@ -323,7 +323,6 @@ def self.build_store(config_map)
     config.add(:poll_rate_for_verify_in_seconds, type: :integer)
     config.add(:proofer_mock_fallback, type: :boolean)
     config.add(:proofing_device_profiling_collecting_enabled, type: :boolean)
-    config.add(:proofing_device_profiling_decisioning_enabled, type: :boolean)
     config.add(:proof_address_max_attempts, type: :integer)
     config.add(:proof_address_max_attempt_window_in_minutes, type: :integer)
     config.add(:proof_ssn_max_attempts, type: :integer)

spec/controllers/idv/gpo_verify_controller_spec.rb

@@ -34,8 +34,6 @@
       and_return(threatmetrix_enabled)
     allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_required_to_verify).
       and_return(threatmetrix_enabled)
-    allow(IdentityConfig.store).to receive(:proofing_device_profiling_decisioning_enabled).
-      and_return(threatmetrix_enabled)
   end
 
   describe '#index' do

spec/controllers/idv/personal_key_controller_spec.rb

@@ -202,7 +202,7 @@ def index
       before do
         ProofingComponent.create(user: user, threatmetrix: true, threatmetrix_review_status: nil)
         allow(IdentityConfig.store).
-          to receive(:proofing_device_profiling_decisioning_enabled).and_return(true)
+          to receive(:lexisnexis_threatmetrix_required_to_verify).and_return(true)
       end
 
       it 'redirects to account path when threatmetrix review status is nil' do

spec/features/idv/in_person_spec.rb

@@ -17,8 +17,6 @@
       allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_enabled).and_return(true)
       allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_required_to_verify).
         and_return(true)
-      allow(IdentityConfig.store).to receive(:proofing_device_profiling_decisioning_enabled).
-        and_return(true)
     end
 
     it 'allows the user to continue down the happy path', allow_browser_log: true do

spec/features/idv/steps/gpo_otp_verification_step_spec.rb

@@ -34,8 +34,6 @@
       and_return(threatmetrix_enabled)
     allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_required_to_verify).
       and_return(threatmetrix_enabled)
-    allow(IdentityConfig.store).to receive(:proofing_device_profiling_decisioning_enabled).
-      and_return(threatmetrix_enabled)
   end
 
   it_behaves_like 'gpo otp verification'

spec/features/idv/threatmetrix_pending_spec.rb

@@ -7,8 +7,6 @@
     allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_enabled).and_return(true)
     allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_required_to_verify).
       and_return(true)
-    allow(IdentityConfig.store).to receive(:proofing_device_profiling_decisioning_enabled).
-      and_return(true)
   end
 
   scenario 'users pending threatmetrix see sad face screen and cannot perform idv' do

spec/forms/gpo_verify_form_spec.rb

@@ -163,8 +163,6 @@
             and_return(true)
           allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_required_to_verify).
             and_return(true)
-          allow(IdentityConfig.store).to receive(:proofing_device_profiling_decisioning_enabled).
-            and_return(true)
         end
 
         it 'returns true' do