Skip to content

Deploy RC 239.1 to Production #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Dec 30, 2022
Merged

Deploy RC 239.1 to Production #7561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e6b54
Remove ThreatMetrix review redirects (#7560)
Dec 30, 2022
b43e993
Remove ThreatMetrix deactivation (#7562)
Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controllers/openid_connect/authorization_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class AuthorizationController < ApplicationController
before_action :bump_auth_count, only: [:index]

def index
return redirect_to_threatmetrix_review if threatmetrix_review_pending_for_ial2_request?
return redirect_to_account_or_verify_profile_url if profile_or_identity_needs_verification?
return redirect_to(sign_up_completed_url) if needs_completion_screen_reason
link_identity_to_service_provider
Expand Down
1 change: 0 additions & 1 deletion app/controllers/saml_idp_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class SamlIdpController < ApplicationController

def auth
capture_analytics
return redirect_to_threatmetrix_review if threatmetrix_review_pending? && ial2_requested?
return redirect_to_verification_url if profile_or_identity_needs_verification_or_decryption?
return redirect_to(sign_up_completed_url) if needs_completion_screen_reason
if auth_count == 1 && first_visit_for_sp?
Expand Down
2 changes: 0 additions & 2 deletions app/forms/gpo_verify_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ def submit
if pending_in_person_enrollment?
UspsInPersonProofing::EnrollmentHelper.schedule_in_person_enrollment(user, pii)
pending_profile&.deactivate(:in_person_verification_pending)
elsif threatmetrix_check_failed?
pending_profile&.deactivate(:threatmetrix_review_pending)
else
activate_profile
end
Expand Down
28 changes: 14 additions & 14 deletions spec/features/idv/steps/gpo_otp_verification_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,21 @@
it_behaves_like 'gpo otp verification'
end

context 'ThreatMetrix says "review"' do
let(:threatmetrix_review_status) { 'review' }
let(:redirect_after_verification) { idv_setup_errors_path }
let(:profile_should_be_active) { false }
let(:expected_deactivation_reason) { 'threatmetrix_review_pending' }
it_behaves_like 'gpo otp verification'
end
# context 'ThreatMetrix says "review"' do
# let(:threatmetrix_review_status) { 'review' }
# let(:redirect_after_verification) { idv_setup_errors_path }
# let(:profile_should_be_active) { false }
# let(:expected_deactivation_reason) { 'threatmetrix_review_pending' }
# it_behaves_like 'gpo otp verification'
# end

context 'ThreatMetrix says "reject"' do
let(:threatmetrix_review_status) { 'reject' }
let(:redirect_after_verification) { idv_setup_errors_path }
let(:profile_should_be_active) { false }
let(:expected_deactivation_reason) { 'threatmetrix_review_pending' }
it_behaves_like 'gpo otp verification'
end
# context 'ThreatMetrix says "reject"' do
# let(:threatmetrix_review_status) { 'reject' }
# let(:redirect_after_verification) { idv_setup_errors_path }
# let(:profile_should_be_active) { false }
# let(:expected_deactivation_reason) { 'threatmetrix_review_pending' }
# it_behaves_like 'gpo otp verification'
# end

context 'No ThreatMetrix result on proofing component' do
let(:threatmetrix_review_status) { nil }
Expand Down