Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions app/services/user_event_creator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,24 @@ def create_out_of_band_user_event(event_type)
create_event_for_device(event_type: event_type, user: current_user, device: nil)
end

def create_out_of_band_user_event_with_disavowal(event_type)
create_event_for_device(
event_type: event_type,
user: current_user,
device: nil,
disavowal_token: build_disavowal_token,
)
end

# @return [Array(Event, String)] an (event, disavowal_token) tuple
def create_user_event_with_disavowal(event_type, user = current_user, device = nil)
disavowal_token = SecureRandom.urlsafe_base64(32)
if device
create_event_for_existing_device(
event_type: event_type, user: user, device: device,
disavowal_token: disavowal_token
disavowal_token: build_disavowal_token
)
else
create_user_event(event_type, user, disavowal_token)
create_user_event(event_type, user, build_disavowal_token)
end
end

Expand All @@ -57,6 +65,10 @@ def create_event_for_existing_device(event_type:, user:, device:, disavowal_toke
)
end

def build_disavowal_token
SecureRandom.urlsafe_base64(32)
end

# @return [Array(Event, String)] an (event, disavowal_token) tuple
def create_event_for_new_device(event_type:, user:, disavowal_token:)
user_has_multiple_devices = UserDecorator.new(user).devices?
Expand Down
21 changes: 17 additions & 4 deletions lib/tasks/review_profile.rake
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,24 @@ namespace :users do
if user.decorate.threatmetrix_review_pending? && user.proofing_component.review_eligible?
result = ProofingComponent.find_by(user: user)
result.update(threatmetrix_review_status: 'pass')
user.profiles.

profile = user.profiles.
where(deactivation_reason: 'threatmetrix_review_pending').
first.
activate
puts "User's review state has been updated to #{result.threatmetrix_review_status}."
first
profile.activate

event, disavowal_token = UserEventCreator.new(current_user: user).
create_out_of_band_user_event_with_disavowal(:account_verified)

UserAlerts::AlertUserAboutAccountVerified.call(
user: user,
date_time: event.created_at,
sp_name: nil,
disavowal_token: disavowal_token,
)

status = result.threatmetrix_review_status
puts "User's review state has been updated to #{status} and the user has been emailed."
elsif !user.proofing_component.review_eligible?
puts 'User is past the 30 day review eligibility'
else
Expand Down
37 changes: 27 additions & 10 deletions spec/lib/tasks/review_profile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,47 @@
require 'rake'

describe 'review_profile' do
let(:user) { create(:user, :deactivated_threatmetrix_profile) }
let(:task_name) { nil }

subject(:invoke_task) do
Rake::Task[task_name].reenable
Rake::Task[task_name].invoke
end

before do
Rake.application.rake_require('lib/tasks/review_profile', [Rails.root.to_s])
Rake::Task.define_task(:environment)
allow(STDIN).to receive(:getpass) { user.uuid }
end

describe 'users:review:pass' do
it 'sets threatmetrix_review_status to pass' do
user = create(:user, :deactivated_threatmetrix_profile)

allow(STDIN).to receive(:getpass) { user.uuid }
let(:task_name) { 'users:review:pass' }

Rake::Task['users:review:pass'].invoke
it 'sets threatmetrix_review_status to pass' do
invoke_task
expect(user.reload.proofing_component.threatmetrix_review_status).to eq('pass')
expect(user.reload.profiles.first.active).to eq(true)
end

it 'dispatches account verified alert' do
freeze_time do
expect(UserAlerts::AlertUserAboutAccountVerified).to receive(:call).with(
user: user,
date_time: Time.zone.now,
disavowal_token: kind_of(String),
sp_name: nil,
)
invoke_task
end
end
end

describe 'users:review:reject' do
it 'sets threatmetrix_review_status to reject' do
user = create(:user, :deactivated_threatmetrix_profile)
let(:task_name) { 'users:review:reject' }

allow(STDIN).to receive(:getpass) { user.uuid }

Rake::Task['users:review:reject'].invoke
it 'sets threatmetrix_review_status to reject' do
invoke_task
expect(user.reload.proofing_component.threatmetrix_review_status).to eq('reject')
expect(user.reload.profiles.first.deactivation_reason).to eq('threatmetrix_review_rejected')
end
Expand Down